Rover: use enumeration entries when sending PID_TUNING message#32301
Open
peterbarker wants to merge 2 commits intoArduPilot:masterfrom
Open
Rover: use enumeration entries when sending PID_TUNING message#32301peterbarker wants to merge 2 commits intoArduPilot:masterfrom
peterbarker wants to merge 2 commits intoArduPilot:masterfrom
Conversation
Add named PID_TUNING_AXIS enum entries for Rover (values 7-11) to the ardupilotmega MAVLink dialect. Values 7 and 8 previously conflicted between Rover and Blimp; Blimp will be allocated separate values in a follow-on change. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Add named PID_TUNING_AXIS enum entries for Rover (values 7-11) to the ardupilotmega MAVLink dialect. Values 7 and 8 previously conflicted between Rover and Blimp; Blimp will be allocated separate values in a follow-on change. Update Rover send_pid_tuning() to use the new named constants in place of raw integer literals. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses enumeration entries instead of integer constants when packaging up a
PID_TUNINGmessage to the GCS.Testing (more checks increases chance of being merged)
Description
Requires ArduPilot/mavlink#482 to add new enumeration values
This will help prevent what conflicts between vehicles. Blimp already conflicts with these values, I'm hoping to convince @MichelleRos to make a breaking change to the blimp code to move to new values for some of the PID_TUNING messages Blimp sends.
It will also help the GCS to present the user with nice names in dropdown boxes etc. for selection of these values.
This is a no-compiler-output change.