Use MAVLink flag value for "unused field" in Rover RC_CHANNELS_SCALED#32299
Open
peterbarker wants to merge 2 commits intoArduPilot:masterfrom
Open
Use MAVLink flag value for "unused field" in Rover RC_CHANNELS_SCALED#32299peterbarker wants to merge 2 commits intoArduPilot:masterfrom
peterbarker wants to merge 2 commits intoArduPilot:masterfrom
Conversation
The MAVLink spec requires inactive channels in RC_CHANNELS_SCALED to be set to UINT16_MAX. Rover only uses channels 1 and 3, but was sending 0 for the unused channels, which means "centre/neutral" rather than "inactive". Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…6_MAX Extend RCOverridesCancel to verify that the inactive channels in RC_CHANNELS_SCALED (2, 4, 5, 6, 7, 8) are set to UINT16_MAX as required by the MAVLink spec. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
peterbarker
force-pushed
the
pr-claude/rover-mavlink-message-uint16_t
branch
from
f924d5f to
0df8aca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes how we emit unused fields in this mavlink message to conform to the spec.
Testing (more check increases chance of being merged)
Description
I don't think we should even really be emitting this message... we don't emit the equivalent on other vehicles AND this isn't a servo-output message, it's an RC-input message!
This is the description from the spec: