CustomBuildServer: Generator checked but no drivers

[rmackay9]

Bug Report

It looks like custom.ardupilot.org builds for CubeOrangePlus on version 4.7.0-beta (and probably 4.8) do not actually include AP_Generator but "Enable Generator" is checked but no drivers are.

This issues was reported by @CraigElder

Platform
[ ] All
[ ] AntennaTracker
[x] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Airframe type
Copter

Hardware type
CubeOrangePlus

[peterbarker]

pbarker@crun:~/rc/ardupilot(master)$ ./Tools/scripts/extract_features.py build/CubeOrangePlus/bin/arducopter | grep -i generator
!AP_GENERATOR_CORTEX_ENABLED
!HAL_GENERATOR_ENABLED
!AP_GENERATOR_IE_2400_ENABLED
!AP_GENERATOR_IE_650_800_ENABLED
!AP_GENERATOR_LOWEHEISER_ENABLED
!AP_GENERATOR_RICHENPOWER_ENABLED
!AP_RPM_GENERATOR_ENABLED
pbarker@crun:~/rc/ardupilot(master)$ 

HAL_GENERATOR_ENABLED should not be checked.

beta features.txt does not have it selected either:

pbarker@crun:~/rc/ardupilot(master)$ wget https://firmware.ardupilot.org/Copter/beta/CubeOrangePlus/features.txt -o /dev/null -O - | grep GENERATOR
!AP_GENERATOR_CORTEX_ENABLED
!HAL_GENERATOR_ENABLED
!AP_GENERATOR_IE_2400_ENABLED
!AP_GENERATOR_IE_650_800_ENABLED
!AP_GENERATOR_LOWEHEISER_ENABLED
!AP_GENERATOR_RICHENPOWER_ENABLED
!AP_RPM_GENERATOR_ENABLED
pbarker@crun:~/rc/ardupilot(master)$ 

@shiv-tyagi ?

[shiv-tyagi]

It is being selected because the features.txt has AP_RPM_DRONECAN_ENABLED as enabled and it depends on HAL_GENERATOR_ENABLED.

I did a quick build and verified that the extra_hwdef.dat includes the define.

Also found these symbols in the binaries which should only be present when HAL_GENERATOR_ENABLED is set.

[peterbarker]

Closed by #33429

[peterbarker]

Fix has been merged into master and is marked for backport to 4.7