Speedup query execution by removing not necessary operations #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While digging into the query execution with the profiler, there were a lot of calls to the toString() of the element of the query AST. This PR optimizes the usage of toString() by caching the string representation. Also, context variables are now always set without the dollar sign ($) as prefix saving one copy of the string per execution.
mergify bot
added a commit
that referenced
this pull request
Oct 26, 2025
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0. Release notes *Sourced from [actions/upload-artifact's releases](https://github.com/actions/upload-artifact/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > **BREAKING CHANGE:** this update supports Node `v24.x`. This is not a breaking change per-se but we're treating it as such. > > * Update README.md by [`@GhadimiR`](https://github.com/GhadimiR) in [actions/upload-artifact#681](https://redirect.github.com/actions/upload-artifact/pull/681) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/upload-artifact#712](https://redirect.github.com/actions/upload-artifact/pull/712) > * Readme: spell out the first use of GHES by [`@danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#727](https://redirect.github.com/actions/upload-artifact/pull/727) > * Update GHES guidance to include reference to Node 20 version by [`@patrikpolyak`](https://github.com/patrikpolyak) in [actions/upload-artifact#725](https://redirect.github.com/actions/upload-artifact/pull/725) > * Bump `@actions/artifact` to `v4.0.0` > * Prepare `v5.0.0` by [`@danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#734](https://redirect.github.com/actions/upload-artifact/pull/734) > > New Contributors > ---------------- > > * [`@GhadimiR`](https://github.com/GhadimiR) made their first contribution in [actions/upload-artifact#681](https://redirect.github.com/actions/upload-artifact/pull/681) > * [`@nebuk89`](https://github.com/nebuk89) made their first contribution in [actions/upload-artifact#712](https://redirect.github.com/actions/upload-artifact/pull/712) > * [`@danwkennedy`](https://github.com/danwkennedy) made their first contribution in [actions/upload-artifact#727](https://redirect.github.com/actions/upload-artifact/pull/727) > * [`@patrikpolyak`](https://github.com/patrikpolyak) made their first contribution in [actions/upload-artifact#725](https://redirect.github.com/actions/upload-artifact/pull/725) > > **Full Changelog**: <actions/upload-artifact@v4...v5.0.0> Commits * [`330a01c`](actions/upload-artifact@330a01c) Merge pull request [#734](https://redirect.github.com/actions/upload-artifact/issues/734) from actions/danwkennedy/prepare-5.0.0 * [`03f2824`](actions/upload-artifact@03f2824) Update `github.dep.yml` * [`905a1ec`](actions/upload-artifact@905a1ec) Prepare `v5.0.0` * [`2d9f9cd`](actions/upload-artifact@2d9f9cd) Merge pull request [#725](https://redirect.github.com/actions/upload-artifact/issues/725) from patrikpolyak/patch-1 * [`9687587`](actions/upload-artifact@9687587) Merge branch 'main' into patch-1 * [`2848b2c`](actions/upload-artifact@2848b2c) Merge pull request [#727](https://redirect.github.com/actions/upload-artifact/issues/727) from danwkennedy/patch-1 * [`9b51177`](actions/upload-artifact@9b51177) Spell out the first use of GHES * [`cd231ca`](actions/upload-artifact@cd231ca) Update GHES guidance to include reference to Node 20 version * [`de65e23`](actions/upload-artifact@de65e23) Merge pull request [#712](https://redirect.github.com/actions/upload-artifact/issues/712) from actions/nebuk89-patch-1 * [`8747d8c`](actions/upload-artifact@8747d8c) Update README.md * Additional commits viewable in [compare view](actions/upload-artifact@ea165f8...330a01c) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergify bot
added a commit
that referenced
this pull request
Nov 5, 2025
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0. Release notes *Sourced from [actions/upload-artifact's releases](https://github.com/actions/upload-artifact/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > **BREAKING CHANGE:** this update supports Node `v24.x`. This is not a breaking change per-se but we're treating it as such. > > * Update README.md by [`@GhadimiR`](https://github.com/GhadimiR) in [actions/upload-artifact#681](https://redirect.github.com/actions/upload-artifact/pull/681) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/upload-artifact#712](https://redirect.github.com/actions/upload-artifact/pull/712) > * Readme: spell out the first use of GHES by [`@danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#727](https://redirect.github.com/actions/upload-artifact/pull/727) > * Update GHES guidance to include reference to Node 20 version by [`@patrikpolyak`](https://github.com/patrikpolyak) in [actions/upload-artifact#725](https://redirect.github.com/actions/upload-artifact/pull/725) > * Bump `@actions/artifact` to `v4.0.0` > * Prepare `v5.0.0` by [`@danwkennedy`](https://github.com/danwkennedy) in [actions/upload-artifact#734](https://redirect.github.com/actions/upload-artifact/pull/734) > > New Contributors > ---------------- > > * [`@GhadimiR`](https://github.com/GhadimiR) made their first contribution in [actions/upload-artifact#681](https://redirect.github.com/actions/upload-artifact/pull/681) > * [`@nebuk89`](https://github.com/nebuk89) made their first contribution in [actions/upload-artifact#712](https://redirect.github.com/actions/upload-artifact/pull/712) > * [`@danwkennedy`](https://github.com/danwkennedy) made their first contribution in [actions/upload-artifact#727](https://redirect.github.com/actions/upload-artifact/pull/727) > * [`@patrikpolyak`](https://github.com/patrikpolyak) made their first contribution in [actions/upload-artifact#725](https://redirect.github.com/actions/upload-artifact/pull/725) > > **Full Changelog**: <actions/upload-artifact@v4...v5.0.0> Commits * [`330a01c`](actions/upload-artifact@330a01c) Merge pull request [#734](https://redirect.github.com/actions/upload-artifact/issues/734) from actions/danwkennedy/prepare-5.0.0 * [`03f2824`](actions/upload-artifact@03f2824) Update `github.dep.yml` * [`905a1ec`](actions/upload-artifact@905a1ec) Prepare `v5.0.0` * [`2d9f9cd`](actions/upload-artifact@2d9f9cd) Merge pull request [#725](https://redirect.github.com/actions/upload-artifact/issues/725) from patrikpolyak/patch-1 * [`9687587`](actions/upload-artifact@9687587) Merge branch 'main' into patch-1 * [`2848b2c`](actions/upload-artifact@2848b2c) Merge pull request [#727](https://redirect.github.com/actions/upload-artifact/issues/727) from danwkennedy/patch-1 * [`9b51177`](actions/upload-artifact@9b51177) Spell out the first use of GHES * [`cd231ca`](actions/upload-artifact@cd231ca) Update GHES guidance to include reference to Node 20 version * [`de65e23`](actions/upload-artifact@de65e23) Merge pull request [#712](https://redirect.github.com/actions/upload-artifact/issues/712) from actions/nebuk89-patch-1 * [`8747d8c`](actions/upload-artifact@8747d8c) Update README.md * Additional commits viewable in [compare view](actions/upload-artifact@v4.6.2...330a01c) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging into the query execution with the profiler, there were a lot of calls to the toString() of the element of the query AST. This PR optimizes the usage of toString() by caching the string representation.
Also, context variables are now always set without the dollar sign ($) as prefix saving one copy of the string per execution.