Fix TypeError when importing JSON graph without settings property#3100
Merged
Fix TypeError when importing JSON graph without settings property#3100
Conversation
Co-authored-by: lvca <[email protected]>
Copilot
AI
changed the title
[WIP] Fix TypeError when importing JSON graph into new DB
Fix TypeError when importing JSON graph without settings property
Jan 9, 2026
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 53e3357. 🟢 All jobs passed!But CI Insights is watching 👀 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
robfrank
pushed a commit
that referenced
this pull request
Feb 11, 2026
) * Initial plan * Fix JSON graph import TypeError when settings property is missing Co-authored-by: lvca <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: lvca <[email protected]> (cherry picked from commit bd45606)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
TypeError: Cannot read properties of undefined (reading 'graphSpacing')when importing JSON graph files that lack asettingsproperty.Motivation
Studio's graph import blindly assigns
globalGraphSettings = globalResultset.settings, causingglobalGraphSettingsto becomeundefinedwhen the imported JSON lacks settings. This breaksrenderGraph()which accessesglobalGraphSettings.graphSpacing.Related issues
Related to graph import functionality in Studio.
Additional Notes
Change: Added conditional check in
studio-graph.js:Also removed duplicate
renderGraph()call outside switch statement.Impact:
Checklist
mvn clean packagecommandWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
scarf.sh/usr/local/bin/node node ./report.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.