Skip to content

#2779 add shading to prometheus plugin #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robfrank merged 1 commit into from
Nov 15, 2025
Merged

#2779 add shading to prometheus plugin #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,14 @@
</dependency>

</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
</plugin>
Comment on lines +64 to +67
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the maven-shade-plugin is correct for bundling dependencies, it's a best practice to also relocate the packages of the shaded dependencies. This prevents potential classpath conflicts if other parts of the application or other plugins use different versions of the same libraries (like Micrometer or Prometheus client). I suggest adding a <configuration> section with <relocations> to move the shaded packages into a private namespace within the arcadedb-metrics artifact.

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-shade-plugin</artifactId>
                <configuration>
                    <relocations>
                        <relocation>
                            <pattern>io.micrometer</pattern>
                            <shadedPattern>com.arcadedb.metrics.shaded.io.micrometer</shadedPattern>
                        </relocation>
                        <relocation>
                            <pattern>io.prometheus</pattern>
                            <shadedPattern>com.arcadedb.metrics.shaded.io.prometheus</shadedPattern>
                        </relocation>
                        <relocation>
                            <pattern>org.hdrhistogram</pattern>
                            <shadedPattern>com.arcadedb.metrics.shaded.org.hdrhistogram</shadedPattern>
                        </relocation>
                        <relocation>
                            <pattern>org.latencyutils</pattern>
                            <shadedPattern>com.arcadedb.metrics.shaded.org.latencyutils</shadedPattern>
                        </relocation>
                    </relocations>
                </configuration>
            </plugin>

</plugins>
</build>

</project>
11 changes: 9 additions & 2 deletions package/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,20 @@
</dependency>
<dependency>
<groupId>com.arcadedb</groupId>
<artifactId>arcadedb-metrics</artifactId>
<artifactId>arcadedb-studio</artifactId>
<version>${project.parent.version}</version>
</dependency>
<dependency>
<groupId>com.arcadedb</groupId>
<artifactId>arcadedb-studio</artifactId>
<artifactId>arcadedb-metrics</artifactId>
<version>${project.parent.version}</version>
<classifier>shaded</classifier>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.arcadedb</groupId>
Expand Down
13 changes: 1 addition & 12 deletions studio/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading