Skip to content

feat: encrypted backup and restore #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvca merged 3 commits into from
May 23, 2025
Merged

feat: encrypted backup and restore #2222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2cca2f
feat: encrypted backup and restore
lvca May 23, 2025
7036e1c
backup encryption: used salt and PBKDF2WithHmacSHA256
lvca May 23, 2025
b127e5b
Following suggestions from gemini code review
lvca May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions engine/src/main/grammar/SQLGrammar.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4189,6 +4189,14 @@ BackupDatabaseStatement BackupDatabaseStatement():
{ }
{
<BACKUP> <DATABASE> [ jjtThis.url = Url() ]
[
<WITH>
jjtThis.key = Expression() <EQ> jjtThis.value = Expression() { jjtThis.settings.put( jjtThis.key, jjtThis.value ); }
(
<COMMA>
jjtThis.key = Expression() <EQ> jjtThis.value = Expression() { jjtThis.settings.put( jjtThis.key, jjtThis.value ); }
)*
]
{return jjtThis; }
}

Expand Down
29 changes: 23 additions & 6 deletions engine/src/main/java/com/arcadedb/query/sql/parser/BackupDatabaseStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,24 @@

import com.arcadedb.GlobalConfiguration;
import com.arcadedb.database.Database;
import com.arcadedb.database.Identifiable;
import com.arcadedb.exception.CommandExecutionException;
import com.arcadedb.log.LogManager;
import com.arcadedb.query.sql.executor.CommandContext;
import com.arcadedb.query.sql.executor.InternalResultSet;
import com.arcadedb.query.sql.executor.ResultInternal;
import com.arcadedb.query.sql.executor.ResultSet;

import java.io.File;
import java.lang.reflect.InvocationTargetException;
import java.util.Map;
import java.util.logging.Level;
import java.io.*;
import java.lang.reflect.*;
import java.util.*;
import java.util.logging.*;

public class BackupDatabaseStatement extends SimpleExecStatement {
protected Url url;
protected Url url;
protected Expression key;
protected Expression value;
protected final Map<Expression, Expression> settings = new HashMap<>();

public BackupDatabaseStatement(final int id) {
super(id);
Expand Down Expand Up @@ -67,8 +71,21 @@ public ResultSet executeSimple(final CommandContext context) {

clazz.getMethod("setDirectory", String.class).invoke(backup, backupDirectory + context.getDatabase().getName());
clazz.getMethod("setVerboseLevel", Integer.TYPE).invoke(backup, 0);
try {

if (!settings.isEmpty()) {
for (Map.Entry<Expression, Expression> entry : settings.entrySet()) {
final String stringValue = entry.getValue().execute((Identifiable) null, context).toString();

switch (entry.getKey().toString()) {
case "encryptionAlgorithm" -> clazz.getMethod("setEncryptionAlgorithm", String.class)
.invoke(backup, stringValue);
case "encryptionKey" -> clazz.getMethod("setEncryptionKey", String.class)
.invoke(backup, stringValue);
}
}
}

try {
final String backupFile = (String) clazz.getMethod("backupDatabase").invoke(backup);
result.setProperty("result", "OK");
result.setProperty("backupFile", backupFile);
Expand Down
Loading
Loading