fix: update backup database functionality and improve logging#2200
Merged
fix: update backup database functionality and improve logging#2200
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes aimed at improving database backup functionality, refining logging, and enhancing code clarity. The most significant updates include modifying backup-related tests to validate output, adding detailed logging for backup operations, and standardizing command context handling.
Database Backup Enhancements:
JdbcQueriesTestandPostgresWJdbcTestto validate theresultandbackupFilefields in theResultSetreturned by theBACKUP DATABASEcommand. This ensures the backup process is functioning correctly and provides meaningful output. [1] [2]FullBackupFormatto ensure that a backup cannot proceed if a transaction is active and has uncommitted changes. This prevents potential data inconsistencies during the backup process.Logging Improvements:
BackupDatabaseStatementto include details about the database being backed up and the target directory. This provides better visibility into backup operations.ArcadeDBServerto display the server root path using the configuration value, ensuring accurate and consistent logging.Codebase Simplifications:
BasicCommandContextwith the more generalCommandContextinPostgresNetworkExecutor, standardizing the handling of command contexts across the codebase. [1] [2]profilingEnabled) from the constructor ofCountFromTypeStep, simplifying the method signature.