Skip to content

fix: update backup database functionality and improve logging#2200

Merged
robfrank merged 1 commit intomainfrom
fix/2116-add-missing-conf
May 10, 2025
Merged

fix: update backup database functionality and improve logging#2200
robfrank merged 1 commit intomainfrom
fix/2116-add-missing-conf

Conversation

@robfrank
Copy link
Collaborator

This pull request introduces several changes aimed at improving database backup functionality, refining logging, and enhancing code clarity. The most significant updates include modifying backup-related tests to validate output, adding detailed logging for backup operations, and standardizing command context handling.

Database Backup Enhancements:

  • Updated backup tests in JdbcQueriesTest and PostgresWJdbcTest to validate the result and backupFile fields in the ResultSet returned by the BACKUP DATABASE command. This ensures the backup process is functioning correctly and provides meaningful output. [1] [2]
  • Added a check in FullBackupFormat to ensure that a backup cannot proceed if a transaction is active and has uncommitted changes. This prevents potential data inconsistencies during the backup process.

Logging Improvements:

  • Enhanced logging in BackupDatabaseStatement to include details about the database being backed up and the target directory. This provides better visibility into backup operations.
  • Refined the server startup log in ArcadeDBServer to display the server root path using the configuration value, ensuring accurate and consistent logging.

Codebase Simplifications:

  • Replaced BasicCommandContext with the more general CommandContext in PostgresNetworkExecutor, standardizing the handling of command contexts across the codebase. [1] [2]
  • Removed an unused parameter (profilingEnabled) from the constructor of CountFromTypeStep, simplifying the method signature.

@robfrank robfrank merged commit 93ed92a into main May 10, 2025
5 of 8 checks passed
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.79% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (540ecc9) 69930 44967 64.30%
Head commit (9a987c1) 66116 (-3814) 43696 (-1271) 66.09% (+1.79%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2200) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@robfrank robfrank deleted the fix/2116-add-missing-conf branch June 20, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant