Skip to content

Add english locale to case conversions #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add english locale to case conversions #1295

merged 1 commit into from
Nov 1, 2023

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Nov 1, 2023

What does this PR do?

These changes add LOCALE.English to all calls of toLowerCase and toUpperCase. For all strings related to commands,keywords or configuration, english localization is obvious, but it seems even for user/data strings LOCALE.English seems to be fine (see here).

Motivation

This is an internationalization best practice in spotbugs.

Additional Notes

The change in .pre-commit-config.yaml was necessary to be able to commit.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-requested a review November 1, 2023 14:18
@lvca lvca added this to the 23.11.1 milestone Nov 1, 2023
@lvca lvca added bug Something isn't working fixed / implemented labels Nov 1, 2023
@lvca lvca merged commit e0fa614 into ArcadeData:main Nov 1, 2023
@lvca
Copy link
Contributor

lvca commented Nov 1, 2023

Thanks for catching this.

mergify bot added a commit that referenced this pull request Sep 8, 2025
@mergify
chore(deps): bump actions/setup-node from 4.4.0 to 5.0.0 [skip ci]
43a08f3 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 5.0.0.
Release notes

*Sourced from [actions/setup-node's releases](https://github.com/actions/setup-node/releases).*

> v5.0.0
> ------
>
> What's Changed
> --------------
>
> ### Breaking Changes
>
> * Enhance caching in setup-node with automatic package manager detection by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-node#1348](https://redirect.github.com/actions/setup-node/pull/1348)
>
> This update, introduces automatic caching when a valid `packageManager` field is present in your `package.json`. This aims to improve workflow performance and make dependency management more seamless. To disable this automatic caching,
> set `package-manager-cache: false`
>
> ```
> steps:
> - uses: actions/checkout@v5
> - uses: actions/setup-node@v5
>   with:
>     package-manager-cache: false
> ```
>
> * Upgrade action to use node24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-node#1325](https://redirect.github.com/actions/setup-node/pull/1325)
>
> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)
>
> ### Dependency Upgrades
>
> * Upgrade `@​octokit/request-error` and `@​actions/github` by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1227](https://redirect.github.com/actions/setup-node/pull/1227)
> * Upgrade uuid from 9.0.1 to 11.1.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1273](https://redirect.github.com/actions/setup-node/pull/1273)
> * Upgrade undici from 5.28.5 to 5.29.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1295](https://redirect.github.com/actions/setup-node/pull/1295)
> * Upgrade form-data to bring in fix for critical vulnerability by [`@​gowridurgad`](https://github.com/gowridurgad) in [actions/setup-node#1332](https://redirect.github.com/actions/setup-node/pull/1332)
> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1345](https://redirect.github.com/actions/setup-node/pull/1345)
>
> New Contributors
> ----------------
>
> * [`@​priya-kinthali`](https://github.com/priya-kinthali) made their first contribution in [actions/setup-node#1348](https://redirect.github.com/actions/setup-node/pull/1348)
> * [`@​salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-node#1325](https://redirect.github.com/actions/setup-node/pull/1325)
>
> **Full Changelog**: <actions/setup-node@v4...v5.0.0>


Commits

* [`a0853c2`](actions/setup-node@a0853c2) Bump actions/checkout from 4 to 5 ([#1345](https://redirect.github.com/actions/setup-node/issues/1345))
* [`b7234cc`](actions/setup-node@b7234cc) Upgrade action to use node24 ([#1325](https://redirect.github.com/actions/setup-node/issues/1325))
* [`d7a1131`](actions/setup-node@d7a1131) Enhance caching in setup-node with automatic package manager detection ([#1348](https://redirect.github.com/actions/setup-node/issues/1348))
* [`5e2628c`](actions/setup-node@5e2628c) Bumps form-data ([#1332](https://redirect.github.com/actions/setup-node/issues/1332))
* [`65becef`](actions/setup-node@65becef) Bump undici from 5.28.5 to 5.29.0 ([#1295](https://redirect.github.com/actions/setup-node/issues/1295))
* [`7e24a65`](actions/setup-node@7e24a65) Bump uuid from 9.0.1 to 11.1.0 ([#1273](https://redirect.github.com/actions/setup-node/issues/1273))
* [`08f58d1`](actions/setup-node@08f58d1) Bump `@​octokit/request-error` and `@​actions/github` ([#1227](https://redirect.github.com/actions/setup-node/issues/1227))
* See full diff in [compare view](actions/setup-node@49933ea...a0853c2)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-node&package-manager=github\_actions&previous-version=4.4.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvca lvca Awaiting requested review from lvca

Assignees

@gramian gramian

Labels

bug Something isn't working fixed / implemented

Projects

None yet

Milestone

23.11.1

Development

Successfully merging this pull request may close these issues.

2 participants

@gramian @lvca