fix: [Bug] AppFlowy crashes on Windows ARM (issue #8491)#8518
Closed
ipezygj wants to merge 13 commits intoAppFlowy-IO:mainfrom
Closed
fix: [Bug] AppFlowy crashes on Windows ARM (issue #8491)#8518ipezygj wants to merge 13 commits intoAppFlowy-IO:mainfrom
ipezygj wants to merge 13 commits intoAppFlowy-IO:mainfrom
Conversation
added 13 commits
February 23, 2026 11:35
Contributor
Reviewer's GuideIntroduces safer YAML config handling for AppFlowy cloud configuration on disk and adds several unrelated AI-generated helper/comments files and noise that should likely be removed from the PR. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
ipezygj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 security issues, 1 other issue, and left some high level feedback:
Security issues:
- Detected subprocess function 'check_output' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'. (link)
- Found 'subprocess' function 'check_output' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead. (link)
General comments:
- The newly added
gandalf_botti.pyappears to be a personal automation tool (includingghusage, token wiring, and branching/PR logic) rather than application/runtime code; consider removing it from the repo or relocating it to a separate tooling repo to avoid leaking local workflows and auth assumptions into the main codebase. - Several
// Gandalf.../// AI fix...comments were added across Rust files without functional changes; these noise comments don’t convey useful information and should be removed to keep the codebase focused and maintainable. - In
read_yaml_file, changing from propagating theserde_yaml::from_strerror tounwrap_or_else(|_| AppFlowyYamlConfiguration::default())silently masks malformed configuration files; consider at least logging or distinguishing between 'file missing/empty' and 'file present but invalid YAML' so configuration problems can be diagnosed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newly added `gandalf_botti.py` appears to be a personal automation tool (including `gh` usage, token wiring, and branching/PR logic) rather than application/runtime code; consider removing it from the repo or relocating it to a separate tooling repo to avoid leaking local workflows and auth assumptions into the main codebase.
- Several `// Gandalf...` / `// AI fix...` comments were added across Rust files without functional changes; these noise comments don’t convey useful information and should be removed to keep the codebase focused and maintainable.
- In `read_yaml_file`, changing from propagating the `serde_yaml::from_str` error to `unwrap_or_else(|_| AppFlowyYamlConfiguration::default())` silently masks malformed configuration files; consider at least logging or distinguishing between 'file missing/empty' and 'file present but invalid YAML' so configuration problems can be diagnosed.
## Individual Comments
### Comment 1
<location> `gandalf_botti.py:66-69` </location>
<code_context>
+ pr_cmd = f"gh pr create --repo AppFlowy-IO/AppFlowy --title 'fix: {title} (issue #{num})' --body '🧙♂️ Gandalf automated fix for issue #{num}' --head {user}:{branch} --base main"
+ print(run_cmd(pr_cmd))
+
+issues = json.loads(run_cmd("gh issue list --limit 5 --json number,title,body"))
+for i in issues:
+ work_on_issue(i)
+ time.sleep(10)
</code_context>
<issue_to_address>
**issue (bug_risk):** Executing networked side effects at import time makes this module unsafe to import.
Because this loop runs at the top level, simply importing the module will trigger forking, branching, committing, pushing, and PR creation, which makes the module unsafe to reuse. Move this logic behind an explicit entry point (e.g., `if __name__ == "__main__":`) so imports are side‑effect free and only direct script execution performs these operations.
</issue_to_address>
### Comment 2
<location> `gandalf_botti.py:9` </location>
<code_context>
return subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT, env=env).decode('utf-8')
</code_context>
<issue_to_address>
**security (python.lang.security.audit.dangerous-subprocess-use-audit):** Detected subprocess function 'check_output' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'.
*Source: opengrep*
</issue_to_address>
### Comment 3
<location> `gandalf_botti.py:9` </location>
<code_context>
return subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT, env=env).decode('utf-8')
</code_context>
<issue_to_address>
**security (python.lang.security.audit.subprocess-shell-true):** Found 'subprocess' function 'check_output' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead.
```suggestion
return subprocess.check_output(cmd, shell=False, stderr=subprocess.STDOUT, env=env).decode('utf-8')
```
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+66
to
+69
| issues = json.loads(run_cmd("gh issue list --limit 5 --json number,title,body")) | ||
| for i in issues: | ||
| work_on_issue(i) | ||
| time.sleep(10) |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Executing networked side effects at import time makes this module unsafe to import.
Because this loop runs at the top level, simply importing the module will trigger forking, branching, committing, pushing, and PR creation, which makes the module unsafe to reuse. Move this logic behind an explicit entry point (e.g., if __name__ == "__main__":) so imports are side‑effect free and only direct script execution performs these operations.
| token = subprocess.getoutput("gh auth token").strip() | ||
| env["GITHUB_TOKEN"] = token | ||
| try: | ||
| return subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT, env=env).decode('utf-8') |
Contributor
There was a problem hiding this comment.
security (python.lang.security.audit.dangerous-subprocess-use-audit): Detected subprocess function 'check_output' without a static string. If this data can be controlled by a malicious actor, it may be an instance of command injection. Audit the use of this call to ensure it is not controllable by an external resource. You may consider using 'shlex.escape()'.
Source: opengrep
| token = subprocess.getoutput("gh auth token").strip() | ||
| env["GITHUB_TOKEN"] = token | ||
| try: | ||
| return subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT, env=env).decode('utf-8') |
Contributor
There was a problem hiding this comment.
security (python.lang.security.audit.subprocess-shell-true): Found 'subprocess' function 'check_output' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead.
Suggested change
| return subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT, env=env).decode('utf-8') | |
| return subprocess.check_output(cmd, shell=False, stderr=subprocess.STDOUT, env=env).decode('utf-8') |
Source: opengrep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧙♂️ Gandalf AI (Claude 4.5 Opus) fix for #8491
Summary by Sourcery
Harden YAML-based cloud configuration handling and introduce an internal automation script, along with minor documentation and comment updates.
New Features:
Enhancements:
Documentation:
Chores: