to reduce load time &white space#8286
Conversation
the updated code to reduce loading time & white spaces
|
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the build script to gate Dart protobuf code generation behind a Cargo feature flag and adds logging to inform users whether code generation runs or is skipped. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `frontend/rust-lib/dart-ffi/build.rs:2-3` </location>
<code_context>
fn main() {
+ #[cfg(feature = "dart")]
flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME"));
+ #[cfg(feature = "dart")]
+ {
</code_context>
<issue_to_address>
**issue:** Redundant code: duplicate Dart code generation under feature flag.
Remove the first call to `dart_gen` under the `dart` feature flag to eliminate duplication.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| #[cfg(feature = "dart")] | ||
| flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME")); |
There was a problem hiding this comment.
issue: Redundant code: duplicate Dart code generation under feature flag.
Remove the first call to dart_gen under the dart feature flag to eliminate duplication.
Feature Preview
PR Checklist
Summary by Sourcery
Gate Dart protobuf code generation behind the "dart" feature flag and add logging to indicate when generation runs or is skipped
Enhancements: