Closed
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhance build.rs in the flowy-error crate to add informative logging around Dart protobuf code generation and handle the case when the Dart feature is not enabled. Flow diagram for updated build.rs Dart code generation logicflowchart TD
A["Start build.rs"] --> B{"Is 'dart' feature enabled?"}
B -- Yes --> C["Print: Generating Dart protobuf code for package" ]
C --> D["Call dart_gen with package name"]
B -- No --> E["Print: Dart feature not enabled; skipping code generation."]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `frontend/rust-lib/flowy-error/build.rs:8-11` </location>
<code_context>
+ flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME"));
+ }
+
+ #[cfg(not(feature = "dart"))]
+ {
+ println!("Dart feature not enabled; skipping code generation.");
+ }
}
</code_context>
<issue_to_address>
**suggestion:** The message for skipping code generation may be unnecessary noise.
Consider removing this print statement or making it conditional on a verbose/debug flag to avoid unnecessary output during normal builds.
```suggestion
#[cfg(not(feature = "dart"))]
{
if std::env::var("FLOWY_VERBOSE").is_ok() || std::env::var("FLOWY_DEBUG").is_ok() {
println!("Dart feature not enabled; skipping code generation.");
}
}
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Improve the build script by adding console output that indicates whether Dart protobuf code generation is running or being skipped based on the Dart feature flag
Build: