Skip to content

Nem Update tabs_bloc.dart#8283

Closed
Madhuz02 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Madhuz02:patch-1
Closed

Nem Update tabs_bloc.dart#8283
Madhuz02 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Madhuz02:patch-1

Conversation

@Madhuz02
Copy link

@Madhuz02 Madhuz02 commented Oct 10, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Enhance tab opening in TabsBloc by debouncing rapid duplicate openPlugin events and clean up formatting in the file

Enhancements:

  • Add deduplication logic to avoid opening the same plugin and view multiple times within a 500 ms window in TabsBloc
  • Introduce tracking fields (_lastOpenedPluginId, _lastOpenedViewId, _lastOpenTime) and a configurable deduplication window

Chores:

  • Remove extraneous whitespace and cleanup formatting in tabs_bloc.dart

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 10, 2025

Reviewer's Guide

The PR adds a deduplication mechanism to skip rapid repeated openPlugin events and cleans up tabs_bloc.dart by removing excessive blank lines and redundant whitespace across methods and imports.

Sequence diagram for deduplication in openPlugin event

sequenceDiagram
    participant TabsBloc
    participant Plugin
    participant ViewPB
    participant State
    actor User
    User->>TabsBloc: Triggers openPlugin(plugin, view)
    TabsBloc->>TabsBloc: Check if plugin and view match last opened
    TabsBloc->>TabsBloc: Check time since last open
    alt Within deduplication window
        TabsBloc-->>User: Ignore event (no action)
    else Outside deduplication window
        TabsBloc->>TabsBloc: Update _lastOpenedPluginId, _lastOpenedViewId, _lastOpenTime
        TabsBloc->>State: Hide secondary plugin
        TabsBloc->>State: Set secondary plugin to BlankPagePlugin
        TabsBloc->>State: Emit openPlugin state
        TabsBloc->>TabsBloc: If setLatest, update latest open view
    end
Loading

File-Level Changes

Change Details Files
Prevent duplicate plugin opens within a short time window
  • Introduce private fields _lastOpenedPluginId, _lastOpenedViewId, _lastOpenTime and a static deduplication window constant
  • In the openPlugin event handler, compare current plugin/view with last opened and skip emit if within the deduplication window
  • Update _lastOpenedPluginId, _lastOpenedViewId, and _lastOpenTime after each valid open
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart
Remove extraneous blank lines and streamline formatting
  • Deleted unnecessary blank lines and stray import separators at the top of the file
  • Cleaned up spacing inside close(), _dispatch, and across event handlers
  • Removed redundant trailing blank lines after methods and at the end of the file
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart:33-35` </location>
<code_context>
+
   @override
   Future<void> close() {
     state.dispose();
+
+    
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Dispose is called before super.close(), which is correct but may need error handling.

Wrap state.dispose() in a try/catch to guarantee super.close() is always called, even if dispose fails.

```suggestion
  @override
  Future<void> close() {
    try {
      state.dispose();
    } catch (e, stackTrace) {
      // Optionally log the error, e.g. using a logger
      // logger.error('Error disposing state', e, stackTrace);
    }
```
</issue_to_address>

### Comment 2
<location> `frontend/appflowy_flutter/lib/workspace/application/tabs/tabs_bloc.dart:55` </location>
<code_context>
     return super.close();
   }
-
   void _dispatch() {
     on<TabsEvent>(
       (event, emit) async {
</code_context>

<issue_to_address>
**issue (bug_risk):** The _dispatch method is not invoked in the constructor.

If event handlers should be registered during initialization, call _dispatch in the constructor to ensure proper setup.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -53,15 +71,13 @@ class TabsBloc extends Bloc<TabsEvent, TabsState> {
if (pm?.isPinned == true) {
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The _dispatch method is not invoked in the constructor.

If event handlers should be registered during initialization, call _dispatch in the constructor to ensure proper setup.


Expand Up

@@ -73,6 +78,22 @@ class TabsBloc extends Bloc<TabsEvent, TabsState> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the code before submitting a PR.

@LucasXu0 LucasXu0 closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants