New Update document_toolbar_test.dart#8281
Closed
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Closed
New Update document_toolbar_test.dart#8281Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Conversation
Contributor
Reviewer's GuideThis PR refactors the document_toolbar integration tests by removing redundant blank lines for cleaner formatting and extends link-handling coverage with a new test that verifies styled text attributes are preserved through link insertion and removal. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- There are stray placeholder lines (e.g. “Expand Down”, “Expand Up”) and duplicated blocks near the end of the file—please remove those to restore valid Dart syntax.
- The new ‘getAttribute’ logic and other selection helpers are duplicated—consider moving them into a shared test utility to reduce boilerplate.
- The heading and toggle tests follow almost identical patterns; try parameterizing them in a loop or table-driven approach to make the code more concise and maintainable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are stray placeholder lines (e.g. “Expand Down”, “Expand Up”) and duplicated blocks near the end of the file—please remove those to restore valid Dart syntax.
- The new ‘getAttribute’ logic and other selection helpers are duplicated—consider moving them into a shared test utility to reduce boilerplate.
- The heading and toggle tests follow almost identical patterns; try parameterizing them in a loop or table-driven approach to make the code more concise and maintainable.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Refine document_toolbar integration tests by cleaning up formatting and adding a new test to ensure text styles persist through link insertion and removal.
Enhancements:
Tests: