New Update math_equation_block_component.dart#8280
Closed
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Closed
New Update math_equation_block_component.dart#8280Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Conversation
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Remove the stray “Expand Down”/“Expand Up” text that was accidentally inserted into the widget build methods so the code compiles and the UI layout remains clear.
- Consider extracting the safeLatex method out of the widget state into a standalone utility or String extension to keep the component focused on UI and improve testability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove the stray “Expand Down”/“Expand Up” text that was accidentally inserted into the widget build methods so the code compiles and the UI layout remains clear.
- Consider extracting the safeLatex method out of the widget state into a standalone utility or String extension to keep the component focused on UI and improve testability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LucasXu0
reviewed
Oct 10, 2025
|
|
||
| Expand Up | ||
|
|
||
| @@ -222,9 +237,10 @@ class MathEquationBlockComponentWidgetState |
Collaborator
There was a problem hiding this comment.
Please verify the code before submitting a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Enable multiline LaTeX rendering in the math equation block via a new preprocessing function and clean up component implementation.
New Features:
Enhancements: