Skip to content

New Update math_equation_block_component.dart#8280

Closed
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Aathish101:patch-4
Closed

New Update math_equation_block_component.dart#8280
Aathish101 wants to merge 1 commit intoAppFlowy-IO:mainfrom
Aathish101:patch-4

Conversation

@Aathish101
Copy link

@Aathish101 Aathish101 commented Oct 9, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Enable multiline LaTeX rendering in the math equation block via a new preprocessing function and clean up component implementation.

New Features:

  • Add safeLatex method to transform formulas with '\' into aligned LaTeX environment for multiline support

Enhancements:

  • Use safeLatex when rendering equations in Math.tex
  • Remove redundant blank lines and simplify component code formatting

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 9, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Remove the stray “Expand Down”/“Expand Up” text that was accidentally inserted into the widget build methods so the code compiles and the UI layout remains clear.
  • Consider extracting the safeLatex method out of the widget state into a standalone utility or String extension to keep the component focused on UI and improve testability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Remove the stray “Expand Down”/“Expand Up” text that was accidentally inserted into the widget build methods so the code compiles and the UI layout remains clear.
- Consider extracting the safeLatex method out of the widget state into a standalone utility or String extension to keep the component focused on UI and improve testability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


Expand Up

@@ -222,9 +237,10 @@ class MathEquationBlockComponentWidgetState
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the code before submitting a PR.

@LucasXu0 LucasXu0 closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants