Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhance build.rs by wrapping Dart protobuf code generation in explicit feature-gated blocks with informative logging for both enabled and disabled states. Flow diagram for updated build.rs feature gating and loggingflowchart TD
A["Start build.rs"] --> B{"Is 'dart' feature enabled?"}
B -- Yes --> C["Print: Generating Dart protobuf code for package"]
C --> D["Call dart_gen with package name"]
B -- No --> E["Print: Dart feature not enabled; skipping code generation."]
D --> F["End"]
E --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `frontend/rust-lib/flowy-error/build.rs:2-3` </location>
<code_context>
fn main() {
#[cfg(feature = "dart")]
flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME"));
+ #[cfg(feature = "dart")]
+ {
</code_context>
<issue_to_address>
**issue:** Duplicate code generation call under the 'dart' feature.
There are two calls to 'dart_gen' under the 'dart' feature; please remove the duplicate to prevent confusion or double execution.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| #[cfg(feature = "dart")] | ||
| flowy_codegen::protobuf_file::dart_gen(env!("CARGO_PKG_NAME")); |
There was a problem hiding this comment.
issue: Duplicate code generation call under the 'dart' feature.
There are two calls to 'dart_gen' under the 'dart' feature; please remove the duplicate to prevent confusion or double execution.
|
|
Feature Preview
PR Checklist
Summary by Sourcery
Enhance the build script to log Dart protobuf code generation and to skip generation when the dart feature is disabled
Enhancements: