-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
RateLimiting: add typed builder/guard tests and external limiter lifetime test #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martincostello
merged 2 commits into
App-vNext:main
from
mohammed-saalim:tests/ratelimiter-additional-cases
Aug 29, 2025
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
test/Polly.RateLimiting.Tests/RateLimiterExternalLimiterLifetimeTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| using System.Threading; | ||
| using System.Threading.RateLimiting; | ||
| using System.Threading.Tasks; | ||
| using Polly.Registry; | ||
| using Shouldly; | ||
|
|
||
| namespace Polly.RateLimiting.Tests | ||
| { | ||
| public class RateLimiterExternalLimiterLifetimeTests | ||
| { | ||
| [Fact] | ||
| public async Task RegistryDispose_DoesNotDisposeExternalLimiter() | ||
| { | ||
| using var externalLimiter = new ConcurrencyLimiter(new ConcurrencyLimiterOptions | ||
| { | ||
| PermitLimit = 1, | ||
| QueueLimit = 0 | ||
| }); | ||
|
|
||
| var registry = new ResiliencePipelineRegistry<string>(); | ||
| _ = registry.GetOrAddPipeline("ext", p => p.AddRateLimiter(externalLimiter)); | ||
|
|
||
| await registry.DisposeAsync(); | ||
|
|
||
| await Should.NotThrowAsync(async () => | ||
| { | ||
| var lease = await externalLimiter.AcquireAsync(1, CancellationToken.None); | ||
| try | ||
| { | ||
| lease.IsAcquired.ShouldBeTrue(); | ||
| } | ||
| finally | ||
| { | ||
| lease.Dispose(); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| } |
53 changes: 53 additions & 0 deletions
53
...ly.RateLimiting.Tests/RateLimiterResiliencePipelineBuilderExtensions_TypedAndNullTests.cs
mohammed-saalim marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| using System; | ||
| using System.ComponentModel.DataAnnotations; | ||
| using Polly.Testing; | ||
| using Shouldly; | ||
|
|
||
| namespace Polly.RateLimiting.Tests | ||
| { | ||
| public class RateLimiterResiliencePipelineBuilderExtensions_TypedAndNullTests | ||
| { | ||
| [Fact] | ||
| public void TypedBuilder_AddConcurrencyLimiter_BuildsRateLimiterStrategy() | ||
| { | ||
| var builder = new ResiliencePipelineBuilder<int>() | ||
| .AddConcurrencyLimiter(permitLimit: 2, queueLimit: 1); | ||
|
|
||
| builder.Build() | ||
| .GetPipelineDescriptor() | ||
| .FirstStrategy | ||
| .StrategyInstance | ||
| .ShouldBeOfType<RateLimiterResilienceStrategy>(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void AddRateLimiter_WithNullLimiter_Throws() | ||
| { | ||
| var builder = new ResiliencePipelineBuilder(); | ||
| Should.Throw<ArgumentNullException>(() => builder.AddRateLimiter(limiter: null!)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void AddRateLimiter_WithNullOptions_Throws() | ||
| { | ||
| var builder = new ResiliencePipelineBuilder(); | ||
| Should.Throw<ArgumentNullException>(() => builder.AddRateLimiter(options: null!)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void AddConcurrencyLimiter_WithNullOptions_Throws() | ||
| { | ||
| var builder = new ResiliencePipelineBuilder(); | ||
| Should.Throw<ArgumentNullException>(() => builder.AddConcurrencyLimiter(options: null!)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void AddRateLimiter_InvalidOptions_ThrowsValidation() | ||
| { | ||
| var builder = new ResiliencePipelineBuilder(); | ||
| var options = new RateLimiterStrategyOptions { DefaultRateLimiterOptions = null! }; | ||
|
|
||
| Should.Throw<ValidationException>(() => builder.AddRateLimiter(options)); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.