docs: dispose registry which contains rate limiters#2438
docs: dispose registry which contains rate limiters#2438lonix1 wants to merge 1 commit intoApp-vNext:mainfrom
Conversation
|
Hey @lonix1 in order to make sure that the sample codes are compling we place them into Please read this documentation: https://github.com/App-vNext/Polly/tree/main/src/Snippets And here you can see a sample PR which updates some code examples inside the Polly docs: https://github.com/App-vNext/Polly/pull/2355/files |
|
Or as an alternative you can place the entire sample code inside the samples folder and refer that inside the docs. |
|
Sorry, I wasn't sure how to do the PR. I'm not a GitHub expert (I'm using the web interface), but I'll see what I can do. |
| return pipeline; | ||
|
|
||
| // else create pipeline with multiple strategies | ||
| var wasCreated = _resiliencePipelineRegistry.TryAddBuilder(partitionKey, (builder, context) => |
There was a problem hiding this comment.
I suggest to take a look at GetOrAddPipeline here. It would make the code simpler.
On your fork you can create a code space to use a Visual Studio Code like web-based environment for development.
|
|
This pull request is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further changes are made. |
|
Hey @lonix1 if you don't have time to finish this then I can take it over in the beginning of April. Do you need my help? |
|
Sorry, I forgot all about this! I'm not a Github expert when it comes to PRs, so if you're willing to take the PR over the finish line I'd appreciate that, thanks. If I recall it was just a documentation change. |
|
My plan is that I will start working on this tomorrow. |
|
@lonix1 Please close this PR |
|
Thank you Peter. |
4 participants
Pull Request
The issue or feature being addressed
Disposal docs
Details on the issue fix or feature implementation
See #2425
Confirm the following
I'm not a GitHub expert, so I hope I did it properly!