Skip to content

Conversation

@Jab2870
Copy link

@Jab2870 Jab2870 commented Nov 10, 2018

This links to the issue #144.

@kevinmu17
Copy link

Why isn't this merged with the master? 2018....

@ApoorvSaxena
Copy link
Owner

@kevinmu17 merge conflicts are yet to be resolved

@kevinmu17
Copy link

kevinmu17 commented Jul 21, 2020

@ApoorvSaxena, from what i can see there is not a merge conflict perse. the src file has to be updated and then the dist shall update to right? The changes are made in a dist file which is wrong right?

const img = document.createElement('img')

it should be change here, but than again, the dist is a production folder and should be reuploaded when creating a build in order to get rid of the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants