Open
Conversation
Owner
|
Thanks for taking the time to contribute @modpotato. |
Anush008
reviewed
Mar 27, 2026
|
|
||
| #[test] | ||
| fn zembed1_embed() { | ||
| if std::env::var("RUN_ZEMBED").is_err() { |
Owner
There was a problem hiding this comment.
Please remove.
We need this test to run in the CI.
Anush008
reviewed
Mar 27, 2026
| "image cosine mismatch: got {image_dot}, expected {expected_dot_from_python}" | ||
| ); | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Please add assertions equating embedding values from the Python counterpart code.
Like we do at https://github.com/Anush008/fastembed-rs/blob/main/tests/text-embeddings.rs
We have ensure Python and Rust produce the same vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cant find any onnx versions so added
ZembedTextEmbeddingalong qwen3 as its the base modelhavent tested personally, cpp linkers broken so workflow tests should catch any bugs i didnt in logic
Resolves #233