Skip to content

FromStr and model_code for EmbeddingModel -- clashes for quantized versions #230

@tr11

Description

@tr11

Currently, the FromStr implementation for the EmbeddingModel enum looks through the model_code field to determine the correct enum variant, which is causing some issues when there are quantized versions available. For example, the EmbeddingModel::NomicEmbedTextV15 and the quantized version EmbeddingModel::NomicEmbedTextV15Q share the same model code, causing issues with the lookup.

Maybe the model codes should be made unique?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions