Merged
Conversation
ErikBjare
reviewed
Jan 22, 2024
Collaborator
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Noticed we use a lot of >= version specifiers that should probably be ^.
This is never a problem for devs (who use dependency locks) but will be a problem for end-users who install via pip, as that might get them a newer version than supported.
While semantic versioning isn't as accepted in Python-land as in JS-land, using ^ has in my experience helped avoid such issues.
ErikBjare
reviewed
Jan 22, 2024
ErikBjare
reviewed
Jan 22, 2024
Co-authored-by: Erik Bjäreholt <[email protected]>
Merged
Owner
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.