image prompts - Entrypoint prompt - additional CLI argument#1077
Merged
image prompts - Entrypoint prompt - additional CLI argument#1077
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 84.45% 84.05% -0.41%
==========================================
Files 26 27 +1
Lines 1396 1486 +90
==========================================
+ Hits 1179 1249 +70
- Misses 217 237 +20 ☔ View full report in Codecov by Sentry. |
TheoMcCabe
reviewed
Mar 20, 2024
| # combined_dict = {**files_dict, **entrypoint} | ||
| # files_dict = FilesDict(combined_dict) | ||
|
|
||
| # entrypoint = gen_entrypoint( |
Collaborator
There was a problem hiding this comment.
are we sure we want commented code here? its always in the git history if we want to bring it back later - or are we expecting this to be commented in and out regularly
| prompt_file : str | ||
| Relative path to a text file containing a prompt. | ||
| entrypoint_prompt_file: str | ||
| Relative path to a text file containing a file that specifies requirements for you entrypoint. |
| messages = ai.next(messages, step_name=curr_fn()) | ||
| edit_refinements += 1 | ||
| files_dict = salvage_correct_hunks(messages, files_dict, problems) | ||
| # if len(problems) > 0: |
Collaborator
There was a problem hiding this comment.
same point about code comments
TheoMcCabe
approved these changes
Mar 20, 2024
Collaborator
|
OK @ATheorell Ive added some docs - and ive tested that its all working. looks good to me now. Im happy to merge - will leave the final review and merge to you? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #1066, which in addition to providing command line arguments to provide a custom prompt file and a directory with images, also allows the user to pass a prompt to generate entry point.
I suggest that we continue with #1066 here @TheoMcCabe
Unfortunately, the PR has drifted a bit and now contains substantial changes