test(learning): add unit tests for learning module#1002
Merged
ATheorell merged 1 commit intoAntonOsika:mainfrom Feb 11, 2024
Merged
test(learning): add unit tests for learning module#1002ATheorell merged 1 commit intoAntonOsika:mainfrom
ATheorell merged 1 commit intoAntonOsika:mainfrom
Conversation
Collaborator
|
Couldn't agree more about the necessity of tests for building confidence in a software. Thanks a lot for this push @MarkVerbeek91 @AntonOsika this is your code as far as I know, could you have a look and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about adding unit test coverage and getting myself familiar with the code. I like the concept of GPT engineer and want to contribute.
To help speed up of development of any software, a trustworthy set of unit test will help. When those tests have a high coverage (90%+) they give confidence to the developer.
In this PR the test coverage of the
gpt_engineer.application.cli.learningmodule is increased to 93%.