fix: ANT-4949 - add cm trajectory deletion logic for dsr#479
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates trajectory unlinking so that removing the last DSR trajectory with time series can also clean up linked DSR capacity-modulation (CM) trajectories. It fits into the trajectory management service by extending detach behavior for DSR-specific dependencies.
Changes:
- Added DSR-specific unlink logic in
TrajectoryServiceImplto detect the last time-series DSR in a study. - Added CM cleanup and orphan-deletion checks when eligible DSR trajectories are detached.
- Added repository support and unit tests for the new CM cleanup flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/com/rte_france/antares/datamanager_back/service/common/impl/TrajectoryServiceImpl.java |
Adds transactional unlink flow, last-DSR detection, and CM trajectory cleanup. |
src/main/java/com/rte_france/antares/datamanager_back/repository/StudyTrajectoryRepository.java |
Adds an existence check used to decide whether a CM trajectory is orphaned. |
src/test/java/com/rte_france/antares/datamanager_back/service/TrajectoryServiceImplTest.java |
Adds unit tests covering orphaned/non-orphaned CM deletion and the non-last-DSR case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
salemsd
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.