Modeler 6.5: valid location [ANT-4045] #3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zakir
reviewed
Nov 27, 2025
a-zakir
reviewed
Nov 27, 2025
a-zakir
reviewed
Nov 28, 2025
a-zakir
reviewed
Nov 28, 2025
a-zakir
reviewed
Nov 28, 2025
| } | ||
| } | ||
|
|
||
| void checkModel(Model& model) |
a-zakir
reviewed
Nov 28, 2025
| } | ||
| } | ||
|
|
||
| void checkLocations(Modeler::Data& data) |
a-zakir
reviewed
Nov 28, 2025
flomnes
reviewed
Dec 2, 2025
Comment on lines
36
to
45
| const std::vector<const Node*> ParentNode::getConstOperands() const | ||
| { | ||
| std::vector<const Node*> constOperands; | ||
| for (const auto* operand: operands_) | ||
| { | ||
| constOperands.push_back(operand); | ||
| } | ||
| return constOperands; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
- Naming You can have 2 member functions with the same name but different constness. The compiler will get the correct one without any problem
- Style You can construct a
std::vectorfrom two iterators
Suggested change
| const std::vector<const Node*> ParentNode::getConstOperands() const | |
| { | |
| std::vector<const Node*> constOperands; | |
| for (const auto* operand: operands_) | |
| { | |
| constOperands.push_back(operand); | |
| } | |
| return constOperands; | |
| } | |
| const std::vector<const Node*> ParentNode::getOperands() const | |
| { | |
| std::vector<const Node*> constOperands(operands_.begin(), operands_.end()); | |
| return constOperands; | |
| } | |
Member
There was a problem hiding this comment.
- Style For a function
f,ReturnType f()andconst ReturnType f()are equivalent
Contributor
Author
There was a problem hiding this comment.
Functions that differ only in their return type cannot be overloaded
ParentNode.h:74:31: note: previous declaration is here [ovl_diff_return_type]
| // Convert the tree to a string, used for error messages | ||
| Expressions::Visitors::PrintVisitor printVisitor; | ||
| std::string nodeExpression = printVisitor.dispatch(n); | ||
|
|
Member
There was a problem hiding this comment.
Print the whole expression, don't bother
Contributor
Author
There was a problem hiding this comment.
Our expression object contains the node, in this instance we only have the node.
I created a function expressionAtPortField to avoid using the printVisitor
src/modeler/checks/include/antares/solver/modeler/checks/checkLocation.h
Show resolved
Hide resolved
flomnes
reviewed
Dec 2, 2025
Comment on lines
36
to
45
| const std::vector<const Node*> ParentNode::getConstOperands() const | ||
| { | ||
| std::vector<const Node*> constOperands; | ||
| for (const auto* operand: operands_) | ||
| { | ||
| constOperands.push_back(operand); | ||
| } | ||
| return constOperands; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
- Style For a function
f,ReturnType f()andconst ReturnType f()are equivalent
flomnes
changed the title
flomnes
approved these changes
Dec 9, 2025
…mulatorTeam/Antares_Simulator into feature/valid-location
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.