feat: add support for SOURCE_BRANCH
#642
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@all-contributors please add @cjlpowers for code |
Contributor
|
I've put up a pull request to add @cjlpowers! 🎉 |
AndreasAugustin
changed the title
SOURCE_BRANCHSOURCE_BRANCH
AndreasAugustin
added
bug
| echo "::group::commit changes" | ||
|
|
||
| # Only commit if merge commit was not already created by git pull | ||
| if git log -1 --pretty=%B | grep -q "Merge"; then |
Owner
There was a problem hiding this comment.
Hi @cjlpowers sorry for my late comment.
Actually I see a small issue with this part. If I understand right it requires that Merge is part of the commit message.
Actually it is not always the case for merge commits.
Possibly there is a better way to find out if it is a merge commit.
| TEMPLATE_REMOTE_GIT_HASH=$(git ls-remote "${SOURCE_REPO}" HEAD | awk '{print $1}') | ||
| # Detect default branch of source repo if SOURCE_BRANCH is not set | ||
| if [[ -z "${SOURCE_BRANCH}" ]]; then | ||
| SOURCE_BRANCH=$(git ls-remote --symref "${SOURCE_REPO}" HEAD 2>/dev/null | awk -F'/' '/^ref:/ {print $NF}' | tr -d '\r\n') |
Owner
There was a problem hiding this comment.
unfortunately the tests are failing with message:
::info::prechecks passed
::info::Missing env variable 'UPSTREAM_BRANCH' setting to remote default main
::info::Detected default branch of source repo: main HEAD
fatal: Needed a single revision
Error: Process completed with exit code 128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #621
See #621 (comment)
Remark
For automation please see closing-issues-using-keywords