-
Notifications
You must be signed in to change notification settings - Fork 79
Support adding guests for outlook #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding guests for outlook #648
Conversation
|
I couldn't add you as reviewer but fyi @AnandChowdhary. Also not sure what I need to do to trigger a release of a new version |
| location: event.location, | ||
| allday: event.allDay || false, | ||
| }; | ||
| if (event.guests && event.guests.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also extract this to a formatGuestEmails and re-use it in all places if you want as we are doing this exact same thing in 6 places
|
Looks great! Can we also please add to README the property? |
I have updated now. Feel free to make any changes as well and have it merged and released when you are ready |
|
Hey @AnandChowdhary could you help me approve and get it released? Thanks |
|
Hey @AnandChowdhary just following up on this. Could you help me merge and get it released please? Thanks |
|
Hey @AnandChowdhary just following up on this |
|
Thank you for your hard work on this! |
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I was looking at at bug report at my workplace as customers are complaining that guests are not added automatically and realised that this library currently doesn't support it.
Did some research and Github Copilot was suggesting that
toquery string key might work which turned out to be working when I tested on outlook.live and outlook.office. Tested with multiple guests too and it is also working on outlook.live. You could try this outhttps://outlook.live.com/calendar/0/action/compose?subject=Test&rru=addevent&startdt=2025-06-12T14:00:00Z&enddt=2025-06-12T15:00:00Z&to=hello%40example.com%2Canother%40example.comwhich has 2 guest emails.I wasn't able to test on other outlook like mobile, 365 mobile though but thought that they all have the same path and query string structure so just added
toto all of them as even if it is invalid, it won't break anything as that would be ignore. If you have a way to test it out that would be great