Skip to content

Conversation

@vietanhtran16
Copy link
Contributor

@vietanhtran16 vietanhtran16 commented May 29, 2025

I was looking at at bug report at my workplace as customers are complaining that guests are not added automatically and realised that this library currently doesn't support it.

Did some research and Github Copilot was suggesting that to query string key might work which turned out to be working when I tested on outlook.live and outlook.office. Tested with multiple guests too and it is also working on outlook.live. You could try this out https://outlook.live.com/calendar/0/action/compose?subject=Test&rru=addevent&startdt=2025-06-12T14:00:00Z&enddt=2025-06-12T15:00:00Z&to=hello%40example.com%2Canother%40example.com which has 2 guest emails.

I wasn't able to test on other outlook like mobile, 365 mobile though but thought that they all have the same path and query string structure so just added to to all of them as even if it is invalid, it won't break anything as that would be ignore. If you have a way to test it out that would be great

@vietanhtran16
Copy link
Contributor Author

vietanhtran16 commented May 29, 2025

I couldn't add you as reviewer but fyi @AnandChowdhary. Also not sure what I need to do to trigger a release of a new version

location: event.location,
allday: event.allDay || false,
};
if (event.guests && event.guests.length) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also extract this to a formatGuestEmails and re-use it in all places if you want as we are doing this exact same thing in 6 places

@AnandChowdhary
Copy link
Owner

Looks great! Can we also please add to README the property?

@vietanhtran16
Copy link
Contributor Author

vietanhtran16 commented May 29, 2025

Looks great! Can we also please add to README the property?

I have updated now. Feel free to make any changes as well and have it merged and released when you are ready

@vietanhtran16
Copy link
Contributor Author

Hey @AnandChowdhary could you help me approve and get it released? Thanks

@vietanhtran16
Copy link
Contributor Author

Hey @AnandChowdhary just following up on this. Could you help me merge and get it released please? Thanks

@vietanhtran16
Copy link
Contributor Author

Hey @AnandChowdhary just following up on this

@AnandChowdhary AnandChowdhary merged commit f1863f6 into AnandChowdhary:master Jun 20, 2025
3 checks passed
@AnandChowdhary
Copy link
Owner

Thank you for your hard work on this!

@FindingAnand
Copy link
Collaborator

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants