Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #81 +/- ##
======================================
Coverage 34.2% 34.2%
======================================
Files 19 19
Lines 4547 4544 -3
======================================
Hits 1554 1554
+ Misses 2993 2990 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…se you cannot pass 0 to windows function
6293
commented
Jun 18, 2023
Comment on lines
645
to
656
| /// If the string register is empty, or destination register can't fit the length, sets `st0` | ||
| /// to `false` and destination register to `None`. | ||
| #[display("len {0},{1}{2}")] | ||
| #[display("len {1}{2},{0}")] | ||
| Len(/** `s` register index */ RegS, RegA, Reg32), | ||
|
|
||
| /// Count number of byte occurrences from the `a8` register within the string and stores that | ||
| /// value into destination `a16` register. | ||
| /// | ||
| /// If the string register is empty, or destination register can't fit the length, sets `st0` | ||
| /// to `false` and destination register to `None`. | ||
| /// | ||
| /// If the source byte value register is uninitialized, sets destination register to `None` and | ||
| /// `st0` to `false`. | ||
| #[display("cnt {0},a8{1},a16{2}")] | ||
| /// If the string register is empty, or the source byte value register is uninitialized, sets | ||
| /// `st0` to `false` and destination register to `None`. | ||
| #[display("cnt a16{2},{0},a8{1}")] | ||
| Cnt( |
Contributor
Author
There was a problem hiding this comment.
unlike len, the return value cannot overflow the destination register which is always a16 in cnt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AluVM/aluasm#11