Skip to content

Pass cargo test --all-features.#61

Merged
dr-orlovsky merged 1 commit intoAluVM:masterfrom
diamondhands-dev:pr-pass-tests
Nov 19, 2022
Merged

Pass cargo test --all-features.#61
dr-orlovsky merged 1 commit intoAluVM:masterfrom
diamondhands-dev:pr-pass-tests

Conversation

@monaka
Copy link
Member

@monaka monaka commented Nov 19, 2022

Before applying this patch, I got errors.

  • error[E0433]: failed to resolve: use of undeclared type Reg8
  • error[E0433]: failed to resolve: use of undeclared type RegBlockAR

Signed-off-by: Masaki Muranaka [email protected]

Before applying this patch, I got errors.

* error[E0433]: failed to resolve: use of undeclared type `Reg8`
* error[E0433]: failed to resolve: use of undeclared type `RegBlockAR`

Signed-off-by: Masaki Muranaka <[email protected]>
@monaka
Copy link
Member Author

monaka commented Nov 19, 2022

Is a CI configuration broken?

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9232205

@dr-orlovsky
Copy link
Member

Seems like you fixed the CI in #62. I am mergning this - the changes are trivial and I will check if the master passes CI after that.

@dr-orlovsky dr-orlovsky merged commit 7eed46e into AluVM:master Nov 19, 2022
@dr-orlovsky
Copy link
Member

Also this should close #60

@monaka monaka deleted the pr-pass-tests branch November 19, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants