Skip to content

Fix invalid st0 use in logs#108

Merged
dr-orlovsky merged 1 commit intoAluVM:masterfrom
fengjian:master
Feb 27, 2024
Merged

Fix invalid st0 use in logs#108
dr-orlovsky merged 1 commit intoAluVM:masterfrom
fengjian:master

Conversation

@fengjian
Copy link
Contributor

warning: variable `st0` is assigned to, but never used
   --> src/library/lib.rs:327:17
    |
327 |         let mut st0 = registers.st0;
    |                 ^^^
    |
    = note: consider using `_st0` instead
    = note: `#[warn(unused_variables)]` on by default

warning: value assigned to `st0` is never read
   --> src/library/lib.rs:356:13
    |
356 |             st0 = registers.st0;
    |             ^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `#[warn(unused_assignments)]` on by default

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 17b340b

@dr-orlovsky
Copy link
Member

Welcome and thank you for finding & fixing!

@dr-orlovsky dr-orlovsky merged commit 23a7328 into AluVM:master Feb 27, 2024
@dr-orlovsky dr-orlovsky changed the title Fix compiler warnings Fix invalid st0 use in logs Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants