Fix cnv macro (and improviment asm_macro)#100
Merged
dr-orlovsky merged 1 commit intoAluVM:masterfrom Jan 18, 2024
Merged
Conversation
This was referenced Jan 15, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
========================================
- Coverage 31.3% 31.2% -0.1%
========================================
Files 23 23
Lines 6431 6467 +36
========================================
+ Hits 2014 2018 +4
- Misses 4417 4449 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dr-orlovsky
reviewed
Jan 18, 2024
Comment on lines
+518
to
+523
| MoveOp::CpyA(sreg, sidx, dreg, didx) => { | ||
| writer.write_u3(sreg)?; | ||
| writer.write_u5(sidx)?; | ||
| writer.write_u3(dreg)?; | ||
| writer.write_u5(didx)?; | ||
| } |
Member
There was a problem hiding this comment.
I wonder why I didn't just compressed all the same serialization into a single case...
dr-orlovsky
approved these changes
Jan 18, 2024
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK 98e1b4c
Thank you for addressing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intent: