Skip to content

[WIP] feat: workflow engine integration #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bjorntore wants to merge 175 commits into
base: main
Choose a base branch
from

Fix InstanceLocker for creation endpoints and add integration test fake

adcf977
Select commit
Loading
Failed to load commit list.
Draft

[WIP] feat: workflow engine integration #1684

Fix InstanceLocker for creation endpoints and add integration test fake
adcf977
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 6, 2026 in 1m 8s

Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 620 in src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WVuRf3m_395OR2k&open=AZzC7WVuRf3m_395OR2k&pullRequest=1684

Check warning on line 77 in src/Altinn.App.Core/Internal/Data/InstanceDataUnitOfWork.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Constructor has 11 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WTmRf3m_395OR2S&open=AZzC7WTmRf3m_395OR2S&pullRequest=1684

Check warning on line 119 in src/Altinn.App.Core/Internal/WorkflowEngine/Commands/ProcessNext/TaskEnd/CommonTaskFinalization.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WXqRf3m_395OR2s&open=AZzC7WXqRf3m_395OR2s&pullRequest=1684

Check warning on line 301 in src/Altinn.App.Core/Internal/Pdf/PdfService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a StringBuilder instead. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WbTRf3m_395OR23&open=AZzC7WbTRf3m_395OR23&pullRequest=1684

Check warning on line 64 in src/Altinn.App.Core/Internal/WorkflowEngine/Http/WorkflowEngineClient.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Exception type System.Exception is not sufficiently specific 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7Wa0Rf3m_395OR20&open=AZzC7Wa0Rf3m_395OR20&pullRequest=1684

Check warning on line 124 in test/Altinn.App.Api.Tests/Mocks/InstanceClientMockSi.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Forward the 'ct' parameter to the 'ReadJsonFile' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WEmRf3m_395OR1q&open=AZzC7WEmRf3m_395OR1q&pullRequest=1684

Check warning on line 424 in test/Altinn.App.Api.Tests/Mocks/InstanceClientMockSi.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Forward the 'ct' parameter to the 'ReadJsonFile' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WEmRf3m_395OR11&open=AZzC7WEmRf3m_395OR11&pullRequest=1684

Check warning on line 546 in src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'System.Exception' should not be thrown by user code. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WVuRf3m_395OR2j&open=AZzC7WVuRf3m_395OR2j&pullRequest=1684

Check warning on line 267 in test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineAuthorizerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzDD2KHQz_sVbjk5g_Q&open=AZzDD2KHQz_sVbjk5g_Q&pullRequest=1684

Check warning on line 607 in src/Altinn.App.Core/Internal/Data/InstanceDataUnitOfWork.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loop should be simplified by calling Select(change => change.DataElementIdentifier)) 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WTmRf3m_395OR2U&open=AZzC7WTmRf3m_395OR2U&pullRequest=1684

Check warning on line 244 in src/Altinn.App.Core/Infrastructure/Clients/Storage/InstanceClient.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use string interpolation in logging message templates. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7Wc5Rf3m_395OR2-&open=AZzC7Wc5Rf3m_395OR2-&pullRequest=1684

Check warning on line 271 in test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineAuthorizerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzDD2KHQz_sVbjk5g_U&open=AZzDD2KHQz_sVbjk5g_U&pullRequest=1684

Check warning on line 9 in src/Altinn.App.Core/Features/IProcessTaskEnd.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WcVRf3m_395OR27&open=AZzC7WcVRf3m_395OR27&pullRequest=1684

Check warning on line 28 in src/Altinn.App.Core/Internal/Process/ProcessTasks/IProcessTask.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All 'End' method overloads should be adjacent. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WUIRf3m_395OR2X&open=AZzC7WUIRf3m_395OR2X&pullRequest=1684

Check warning on line 328 in src/Altinn.App.Core/Internal/Pdf/PdfService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter 'instance'. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WbTRf3m_395OR24&open=AZzC7WbTRf3m_395OR24&pullRequest=1684

Check warning on line 1441 in src/Altinn.App.Api/Controllers/InstancesController.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WQRRf3m_395OR2M&open=AZzC7WQRRf3m_395OR2M&pullRequest=1684

Check warning on line 269 in test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineAuthorizerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzDD2KHQz_sVbjk5g_S&open=AZzDD2KHQz_sVbjk5g_S&pullRequest=1684

Check warning on line 321 in test/Altinn.App.Api.Tests/Mocks/InstanceClientMockSi.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Forward the 'ct' parameter to the 'GetInstance' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WEmRf3m_395OR1u&open=AZzC7WEmRf3m_395OR1u&pullRequest=1684

Check warning on line 268 in test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineAuthorizerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzDD2KHQz_sVbjk5g_R&open=AZzDD2KHQz_sVbjk5g_R&pullRequest=1684

Check warning on line 36 in src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Private member 'ProcessEngine.MaxNextIterationsAllowed' is unused 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WVuRf3m_395OR2o&open=AZzC7WVuRf3m_395OR2o&pullRequest=1684

Check warning on line 1017 in test/Altinn.App.Core.Tests/Internal/Process/ProcessEngineTest.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Dereference of a possibly null reference. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzDD2NDQz_sVbjk5g_c&open=AZzDD2NDQz_sVbjk5g_c&pullRequest=1684

Check warning on line 231 in src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WVuRf3m_395OR2i&open=AZzC7WVuRf3m_395OR2i&pullRequest=1684

Check warning on line 34 in src/Altinn.App.Core/Internal/WorkflowEngine/Commands/ProcessNext/ProcessEnd/DeleteInstance.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WXzRf3m_395OR2u&open=AZzC7WXzRf3m_395OR2u&pullRequest=1684

Check warning on line 543 in src/Altinn.App.Core/Internal/Process/ProcessEngine.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WVuRf3m_395OR2d&open=AZzC7WVuRf3m_395OR2d&pullRequest=1684

Check warning on line 171 in src/Altinn.App.Core/Internal/Pdf/PdfService.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZzC7WbTRf3m_395OR22&open=AZzC7WbTRf3m_395OR22&pullRequest=1684
View more details on SonarQubeCloud