Skip to content

Set data field by expression #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olavsorl wants to merge 16 commits into
base: main
Choose a base branch
from

Fixed DI

1f961e4
Select commit
Loading
Failed to load commit list.
Open

Set data field by expression #1683

Fixed DI
1f961e4
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 10, 2026 in 1m 2s

Quality Gate failed

Failed conditions
30.8% Coverage on New Code (required ≥ 65%)
E Security Rating on New Code (required ≥ A)
32.2% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 402 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocz&open=AZy-iQnyhgA_Kbzevocz&pullRequest=1683

Check warning on line 360 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocx&open=AZy-iQnyhgA_Kbzevocx&pullRequest=1683

Check warning on line 360 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocU&open=AZy-iQkPhgA_KbzevocU&pullRequest=1683

Check warning on line 32 in src/Altinn.App.Core/Internal/Expressions/ExpressionHelper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not update the stop condition variable 'index' in the body of the for loop. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQmXhgA_Kbzevock&open=AZy-iQmXhgA_Kbzevock&pullRequest=1683

Check failure on line 81 in src/Altinn.App.Core/Implementation/AppResourcesSI.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the path from user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQvqhgA_Kbzevodf&open=AZy-iQvqhgA_Kbzevodf&pullRequest=1683

Check warning on line 116 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocR&open=AZy-iQkPhgA_KbzevocR&pullRequest=1683

Check warning on line 237 in src/Altinn.App.Core/Internal/Expressions/LayoutEvaluatorState.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQk9hgA_Kbzevocf&open=AZy-iQk9hgA_Kbzevocf&pullRequest=1683

Check warning on line 402 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders in the logging message template 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevoc4&open=AZy-iQnyhgA_Kbzevoc4&pullRequest=1683

Check warning on line 235 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders in the logging message template 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevoc1&open=AZy-iQnyhgA_Kbzevoc1&pullRequest=1683

Check warning on line 331 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocw&open=AZy-iQnyhgA_Kbzevocw&pullRequest=1683

Check warning on line 468 in src/Altinn.App.Core/Implementation/AppResourcesSI.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the path from user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQvqhgA_Kbzevodj&open=AZy-iQvqhgA_Kbzevodj&pullRequest=1683

Check warning on line 47 in src/Altinn.App.Core/Internal/Data/IFormDataWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename virtual/interface member IFormDataWrapper.Set(ReadOnlySpan<char>, ExpressionValue) so that it no longer conflicts with the reserved language keyword 'Set'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQjUhgA_KbzevocO&open=AZy-iQjUhgA_KbzevocO&pullRequest=1683

Check warning on line 235 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocp&open=AZy-iQnyhgA_Kbzevocp&pullRequest=1683

Check warning on line 39 in src/Altinn.App.Core/Internal/Data/IFormDataWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename virtual/interface member IFormDataWrapper.Get(ReadOnlySpan<char>) so that it no longer conflicts with the reserved language keyword 'Get'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQjUhgA_KbzevocN&open=AZy-iQjUhgA_KbzevocN&pullRequest=1683

Check warning on line 137 in src/Altinn.App.Core/Internal/App/IAppResources.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQm3hgA_Kbzevocm&open=AZy-iQm3hgA_Kbzevocm&pullRequest=1683

Check warning on line 143 in src/Altinn.App.Core/Features/DataProcessing/DataFieldValueCalculator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log this exception and handle it, or rethrow it with some contextual information. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQs9hgA_Kbzevoc7&open=AZy-iQs9hgA_Kbzevoc7&pullRequest=1683

Check warning on line 268 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'false' 7 times. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocY&open=AZy-iQkPhgA_KbzevocY&pullRequest=1683

Check warning on line 616 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_KbzevocV&open=AZy-iQkPhgA_KbzevocV&pullRequest=1683

Check warning on line 321 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocv&open=AZy-iQnyhgA_Kbzevocv&pullRequest=1683

Check failure on line 477 in src/Altinn.App.Core/Internal/Expressions/ExpressionValue.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQkPhgA_Kbzevoca&open=AZy-iQkPhgA_Kbzevoca&pullRequest=1683

Check warning on line 272 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocr&open=AZy-iQnyhgA_Kbzevocr&pullRequest=1683

Check warning on line 91 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevocn&open=AZy-iQnyhgA_Kbzevocn&pullRequest=1683

Check warning on line 278 in src/Altinn.App.Core/Features/Validation/Default/ExpressionValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use PascalCase for named placeholders in the logging message template 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQnyhgA_Kbzevoc3&open=AZy-iQnyhgA_Kbzevoc3&pullRequest=1683

Check warning on line 110 in src/Altinn.App.Core/Internal/Expressions/LayoutEvaluatorState.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQk9hgA_Kbzevocd&open=AZy-iQk9hgA_Kbzevocd&pullRequest=1683

Check warning on line 332 in src/Altinn.App.Core/Internal/Expressions/LayoutEvaluatorState.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=Altinn_app-lib-dotnet&issues=AZy-iQk9hgA_Kbzevocg&open=AZy-iQk9hgA_Kbzevocg&pullRequest=1683
View more details on SonarQubeCloud