Conversation
|
I think we shouldn't add the "common" hsts-header here and just let the app default to the hsts in -n traefik, which will be there anyway, as it's deployed by the platform @bengtfredh - what do you think? |
| readinessProbe: | ||
| httpGet: | ||
| path: /health | ||
| port: {{ .Values.service.internalPort }} | ||
|
|
||
| initialDelaySeconds: 30 | ||
| failureThreshold: 3 | ||
| periodSeconds: 3 | ||
| timeoutSeconds: 1 | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /health | ||
| port: {{ .Values.service.internalPort }} | ||
| initialDelaySeconds: 3 | ||
| failureThreshold: 3 | ||
| periodSeconds: 10 | ||
| timeoutSeconds: 2 |
There was a problem hiding this comment.
Should we make it possible to change the liveness/readiness probes?
Also should we add a default startup probe?
Middleware is namespaced, so apps can not use hsts defined in -n traefik. If this deployment dont add it - we need to create it another way. |
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>
Ah, interesting, didn't know that. Should be added here then. |
| name: {{ .Values.appName }} | ||
| labels: | ||
| {{- include ".Chart.Name.labels" . | nindent 4 }} | ||
| spec: |
There was a problem hiding this comment.
add optional config for dual stack.
spec:
ipFamilyPolicy: PreferDualStack
ipFamilies:
- IPv4
- IPv6There was a problem hiding this comment.
Would this break in a non dual-stack cluster?
There was a problem hiding this comment.
From what I can find. PreferDualStack is safe on non-dual-stack; just don’t use RequireDualStack unless you’re sure the cluster supports it.
You where thinking to make it default?
There was a problem hiding this comment.
We made it default but optional in deployment chart:
05d3acd#diff-55f3c921ec57f475e38963114bc7afc38b746a6acc33b6641182d13be3be13c8
There was a problem hiding this comment.
I assumed it would be ok when it says prefer, but was in doubt so asked.
Description
Related Issue(s)
Verification
Documentation