Skip to content

Conversation

@ianton-ru
Copy link

Changelog category (leave one):

  • New Feature

Changelog entry (a [user-readable short description]

Frontports for Antalya 25.6.5

#592
#615
#648
#675
#677
#712
#710
#719
#746
#750
#761

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Workflow [PR], commit [83e08a7]

@ianton-ru ianton-ru changed the title 25.6 Antalya port - Alternative syntax for cluster functions 25.6.5 Antalya port - Alternative syntax for cluster functions Aug 5, 2025
Copy link
Collaborator

@zvonand zvonand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of stateless fails -- but they are failing in other PRs also and do not look related. Build fail is also not related

@ianton-ru ianton-ru mentioned this pull request Aug 22, 2025
13 tasks
@zvonand

This comment was marked as duplicate.

Copy link
Collaborator

@zvonand zvonand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR (not exactly this forward-port, but #615) causes #954

Tl;dr: show tables from glue throws exception if it has access to table info in glue but has no rights to read the table files from s3. Upstream allows to show tables or even show create ... in this case

@ianton-ru
Copy link
Author

Looks like this PR (not exactly this forward-port, but #615) causes #954

Tl;dr: show tables from glue throws exception if it has access to table info in glue but has no rights to read the table files from s3. Upstream allows to show tables or even show create ... in this case

Not sure. Exception Exception calling GetTable for table is from GlueCatalog::getTableMetadata
https://github.com/Altinity/ClickHouse/blob/antalya-25.3/src/Databases/DataLake/GlueCatalog.cpp#L389
when glue_client->GetTable request is not success.
It's a GlueClient from AWS SDK
https://github.com/ClickHouse/aws-sdk-cpp/blob/a9e7b95baa04b28827d0b22eb08414907b595531/generated/src/aws-cpp-sdk-glue/include/aws/glue/GlueClient.h

@zvonand
Copy link
Collaborator

zvonand commented Aug 28, 2025

Maybe you are right actually.

This was a bug in all of 25.3 Antalya versions, so I found out #615 was the issue by going through all commits. However, I did not find an obvious connection to the PR itself either.

Now I re-checked if the issue is present in this (25.6 forwardport) branch -- and everything is fine here. Maybe it will be gone in our 25.6 Antalya without further actions :)
Maybe that was an issue with incorrect forwardport to 25.3, IDK

Let's wait until all forward ports are merged and see if it is still present then

@ianton-ru
Copy link
Author

ianton-ru commented Aug 29, 2025

@zvonand Sorry, I've seen an incorrect exception, correct is

 User: arn:aws:iam::407099639081:user/glue_clickhouse_regression_test_user is not authorized to perform: s3:GetObject...

Must be fixed in 25.6 with this commit
cf3e774

@Enmk Enmk merged commit af5b44d into antalya-25.6.5 Sep 8, 2025
101 of 104 checks passed
ianton-ru pushed a commit that referenced this pull request Oct 1, 2025
…ive_syntax

25.8 Antalya port - Alternative syntax for cluster functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants