Skip to content

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Jul 16, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add _time virtual column in S3Queue engine (ClickHouse#78926 by @ianton-ru)

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Add _time virtual column in S3Queue engine
@zvonand
Copy link
Collaborator Author

zvonand commented Jul 16, 2025

@ianton-ru there are test fails that maybe look related to your changes: test_storage_s3_queue/test_4.py::test_alter_settings. Could you please take a look?

Maybe not related, just to be double sure

@ianton-ru
Copy link

@ianton-ru there are test fails that maybe look related to your changes: test_storage_s3_queue/test_4.py::test_alter_settings. Could you please take a look?

Maybe not related, just to be double sure

@zvonand looks unrelated. query select alterable from system.s3_queue_settings where name = 'processing_threads_num' returns two rows instead of expected one. It's very strange and possible a bug, but PR should not affect this.

@zvonand zvonand merged commit ad99ec2 into releases/25.3.6 Jul 18, 2025
149 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants