24.8 Avoid leaking AWS secrets via logs

[Enmk]

Changelog category (leave one):

• Not for changelog (changelog entry is not required)

Exclude tests:

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Performance tests
• All with ASAN
• All with TSAN
• All with MSAN
• All with UBSAN
• All with Coverage
• All with Aarch64

[MyroTk]

We can remove the credentials from the function inputs

ClickHouse/docker/packager/packager

Line 149 in 1978b14

s3_access_key_id: str,

ClickHouse/docker/packager/packager

Line 153 in 1978b14

s3_secret_access_key: str,

and then the commented out ones as well

ClickHouse/docker/packager/packager

Line 563 in 1978b14

"", #args.s3_access_key_id,

ClickHouse/docker/packager/packager

Line 567 in 1978b14

"", #args.s3_secret_access_key,

[Enmk]

We can remove the credentials from the function inputs

My motivation was to stick as close to upstream as possible to avoid merge conflicts down the road, when we are going to port that to the other versions...

[MyroTk]

Actually removing them would be closer to upstream - for example, 24.8 doesn't have them https://github.com/ClickHouse/ClickHouse/blob/24.8/docker/packager/packager . Same with master

[Enmk]

Continued in #693