23.3.5 Pre-release

[Enmk]

Based on Upstream's v23.3.5.9-lts

Bug fixes

• Fix key condition on duplicate primary keys (Fix key condition on duplicate primary keys ClickHouse/ClickHouse#48838 by @amosbird via 23.3 backport of #48838 Fix crash with key condition on duplicate primary keys #275 )

Performance improvement

• Do not build sets for skip indexes if they are not used (Do not build sets for skip indexes if they are not used ClickHouse/ClickHouse#48299 by @CurtizJ via 23.3 backport of #48299 Do not build skip indices if not used  #276)

Build/Testing/Packaging Improvement

Make builds and tests possible in Altinity's infrastructure

• add comment and rename github robot token

• add clickhouse instance password parameter

• use Altinity's s3 bucket

• Use altinityinfra dockerhub images and minor adjustments (Use altinityinfra dockerhub images and minor adjustments #135)

• Allow CI to be triggered on PR

• Proper error reporting during docker pull and lowercase version name allow altinitystable git tags

• Download specific MinIO version instead of latest - same as upstream master remove stale chmod

• More stable CI/CD builds:

  • Rebuilding all docker images
  • Reduced number of docker images
  • Rerunning functional tests even if those were already executed in previous run Added missing dependencies for stateful tests

• Re-generating _pb2 files on each test run

• Changed hardcoded docker images name prefixes from clickhouse/ to altinityinfra/

• Pushing images as :latest too to avoid some test failures

• Fixed how version is generated: taking into account VERSION_TWEAK and VERSION_FLAVOUR

• Pushing checks events data to "gh-data" instead of "default"

• Using secrets for managing AWS access

• Fixed tag checking code to allow altinitystable version suffix

• Bumped Go version to get some CVE fixes

• Do not install clickhouse-diagnostics due to numerous CVEs in go runtime

• Removed unneeded docker images from list: codebrowser, sqlancer-test, keeper-jespen, keeper-jepsen-test, testflows-runner, fuzzer Using ccache instead of sccache

• Fixed ClickHouseVersion.get_version_from_string for some cases, fixed getting version flavour

[altinity-robot]

This is an automated comment for commit 14d071b with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟡 pending
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🔴 failure
Mergeable Check	Checks if all other necessary checks are successful	🔴 failure
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
Ready for release	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🔴 failure