Skip to content

22.8 backport of #47958 unit test assert arrow doesn't crash #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enmk merged 1 commit into from
Mar 27, 2023
Merged

22.8 backport of #47958 unit test assert arrow doesn't crash #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ if (ENABLE_TESTS)
dbms
clickhouse_common_config
clickhouse_common_zookeeper
ch_contrib::parquet
string_utils)

if (TARGET ch_contrib::simdjson)
Expand Down
18 changes: 18 additions & 0 deletions src/Processors/tests/gtest_assert_arrow_log_does_not_abort.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#include <gtest/gtest.h>
#include <arrow/chunked_array.h>
#include <vector>
#include <arrow/util/logging.h>

using namespace DB;

TEST(ChunkedArray, ChunkedArrayWithZeroChunksShouldNotAbort)
{
std::vector<std::shared_ptr<::arrow::Array>> empty_chunks_vector;

EXPECT_ANY_THROW(::arrow::ChunkedArray{empty_chunks_vector});
}

TEST(ArrowLog, FatalLogShouldThrow)
{
EXPECT_ANY_THROW(::arrow::util::ArrowLog(__FILE__, __LINE__, ::arrow::util::ArrowLogLevel::ARROW_FATAL));
}