Cleanup export manifests - attempt to prevent crash #1167
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| std::erase_if(export_manifests, [&](const auto & manifest) | ||
| { | ||
| if (manifest.transaction_id == transaction_id) | ||
| { | ||
| if (manifest.task) | ||
| manifest.task->cancel(); | ||
|
|
||
| return true; | ||
| } | ||
| return false; | ||
| return manifest.transaction_id == transaction_id; |
There was a problem hiding this comment.
killExportPart now only erases the manifest from export_manifests and no longer cancels the associated ExportPartTask. If KILL EXPORT PARTITION or the manifest update task hits this branch while an export is already scheduled or executing, the background task keeps running and will still write the part despite the cancellation request. Prior behavior invoked task->cancel() here, so in-flight exports can no longer be stopped.
Useful? React with 👍 / 👎.
arthurpassos
added
antalya
port-antalya
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Cleanup export manifests upon table shutdown so part references are gracefully destroyed before storages destructor
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: