-
Notifications
You must be signed in to change notification settings - Fork 9
Fix flakiness in tests by adding status poll instead of random sleeps #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests/integration/test_export_replicated_mt_partition_to_object_storage/test.py
Outdated
Show resolved
Hide resolved
mkmkme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for explanation :)
1763658360 - 1763658365 = 5
Gosh, for 1 freaking second :D |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Try to fix flakiness by polling instead of random sleeps
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: