Skip to content

Conversation

@ianton-ru
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

More virtual methods for StorageObjectStorageCluster

Documentation entry for user-facing changes

Some methods were not overridden in StorageObjectStorageCluster, some features can be turned off (like PREWHERE).

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

Workflow [PR], commit [872f4c0]

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ianton-ru
Copy link
Author

@Enmk This s a fix required for proper backport of 87220 working.

@mkmkme
Copy link
Collaborator

mkmkme commented Nov 13, 2025

Quite odd that the test has failed. @ianton-ru do you think it's related?
It doesn't seem to be the flaky test from my perspective. Could you perhaps double-check?

@ianton-ru
Copy link
Author

Quite odd that the test has failed. @ianton-ru do you think it's related? It doesn't seem to be the flaky test from my perspective. Could you perhaps double-check?

Don't think so,
01079_parallel_alter_detach_table_zookeeper failed with timeout during detach table on one node from three. Table has ReplicatedMergeTree engine. I don't think current PR can affect this.

Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk
Copy link
Member

Enmk commented Nov 13, 2025

@ianton-ru BTW, if that affects PREWHERE, why wasn't it detected by the tests?

@Enmk Enmk merged commit 615b144 into antalya-25.8 Nov 13, 2025
135 of 138 checks passed
@ianton-ru
Copy link
Author

@ianton-ru BTW, if that affects PREWHERE, why wasn't it detected by the tests?

I think this case was not covered by any test before #1136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants