Skip to content

Fix prefersLargeBlocks for cluster storage #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enmk merged 2 commits into from
Oct 13, 2025
Merged

Fix prefersLargeBlocks for cluster storage #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb19c9
Fix prefersLargeBlocks for cluster storage
ianton-ru Oct 13, 2025
2d4ca2f
Merge branch 'antalya-25.8' into bugfix/antalya-25.8/prefer_large_blocks
ianton-ru Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,4 +872,11 @@ void StorageObjectStorageCluster::onActionLockRemove(StorageActionBlockType acti
IStorageCluster::onActionLockRemove(action_type);
}

bool StorageObjectStorageCluster::prefersLargeBlocks() const
{
if (pure_storage)
return pure_storage->prefersLargeBlocks();
return IStorageCluster::prefersLargeBlocks();
}

}
2 changes: 2 additions & 0 deletions src/Storages/ObjectStorage/StorageObjectStorageCluster.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ class StorageObjectStorageCluster : public IStorageCluster

void onActionLockRemove(StorageActionBlockType action_type) override;

bool prefersLargeBlocks() const override;

private:
void updateQueryToSendIfNeeded(
ASTPtr & query,
Expand Down
Loading