Skip to content

Conversation

@filimonov
Copy link
Member

@filimonov filimonov commented Oct 10, 2025

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

engine=Hybrid implementation

Documentation entry for user-facing changes

Missing parts & known issues:

  • virtual column is not implemented
  • support for eliminating the layers with always-false predicate combination
  • automatic normalization of aggregate function arguments
  • some refactoring / code reorganization

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Workflow [PR], commit [b28b8ed]

@filimonov filimonov mentioned this pull request Oct 10, 2025
13 tasks
@filimonov filimonov force-pushed the mf-25.8-tiered-distributed branch from 09b83a1 to 39c6725 Compare October 10, 2025 11:21
}
}

void StorageDistributed::setAdditionalTableFunctions(std::vector<TableFunctionEntry> additional_table_functions_)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe i'll rename it to smth like setTieredLayout

@filimonov
Copy link
Member Author

Failures - are minor (need to adjust the test for distributed plan)

@ianton-ru
Copy link

I can understand near 20% of code - that code is LGTM. :)

@filimonov filimonov force-pushed the mf-25.8-tiered-distributed branch from 39c6725 to 7bea2f1 Compare October 13, 2025 21:51
@filimonov filimonov changed the title Tiered distributed engine=Hybrid Oct 13, 2025
ianton-ru
ianton-ru previously approved these changes Oct 14, 2025
@filimonov
Copy link
Member Author

Test failures:

02210_processors_profile_log

https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=1071&sha=b28b8ed30ae3f637070e5063ff97a49cc47f11fe&name_0=PR&name_1=Stateless+tests+%28amd_binary%2C+ParallelReplicas%2C+s3+storage%2C+parallel%29&name_2=Tests

probably a timer accuracy issue (less than 20 microseconds of mistake)

Potential fix is smth like

tests/queries/0_stateless/02210_processors_profile_log.sql (+2 -1)
24             -- so it cannot starts to execute before sleep(1) will be executed.
25    -        input_wait_elapsed_us>=1e6 ? 1 : input_wait_elapsed_us)
25    +        -- CLOCK_MONOTONIC_COARSE may report slightly less than 1e6 us, so use same tolerance.
26    +        input_wait_elapsed_us>=0.99e6 ? 1 : input_wait_elapsed_us)
27         elapsed,

Unrelated.

@filimonov
Copy link
Member Author

filimonov commented Oct 14, 2025

  • 03441_deltalake_clickhouse_public_datasets + 03441_deltalake_clickhouse_virtual_columns

https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=1071&sha=b28b8ed30ae3f637070e5063ff97a49cc47f11fe&name_0=PR&name_1=Stateless+tests+%28amd_binary%2C+ParallelReplicas%2C+s3+storage%2C+parallel%29&name_2=Tests

Looks like a known issue (something with IPv6 stack?)

@Enmk Enmk merged commit cf4d137 into antalya-25.8 Oct 15, 2025
136 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants