Skip to content

Conversation

@suavesav
Copy link

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

@suavesav suavesav changed the base branch from main to 0.62.x June 21, 2024 19:12
@suavesav suavesav changed the base branch from 0.62.x to main June 21, 2024 19:13
@suavesav suavesav changed the base branch from main to 0.63.3.branch June 21, 2024 19:25
Copy link

@thomaswrenn thomaswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed Commit 1, and read Commit 2.

If the live manual testing for all login types are good and the tests are passing in vishnu-backend then seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants