bugfix: pull image and get its status with RefDigest #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
refactor-image
branch
3 times, most recently
from
0a418d8 to
4537896
Compare
faycheng
reviewed
Mar 27, 2018
daemon/mgr/image.go
Outdated
| id = c.refToID[refTagged.String()] | ||
| } | ||
| if id == "" { | ||
| return nil, errors.Wrap(errtypes.ErrNotfound, "image: "+id) |
There was a problem hiding this comment.
error msg is incomplete while using repoDigest，maybe we should raise error on line 258.
Error: failed to run container: {"message":"image: : not found"}
YaoZengzeng
force-pushed
the
refactor-image
branch
from
4537896 to
0f4d1fd
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
refactor-image
branch
from
0f4d1fd to
9ae25a4
Compare
YaoZengzeng
force-pushed
the
refactor-image
branch
2 times, most recently
from
00bc1a6 to
dfdfa3f
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
refactor-image
branch
from
dfdfa3f to
7f18fa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 12.94% 12.95% +0.01%
==========================================
Files 123 123
Lines 8314 8322 +8
==========================================
+ Hits 1076 1078 +2
- Misses 7142 7151 +9
+ Partials 96 93 -3
Continue to review full report at Codecov.
|
|
@allencloud PTAL. |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews