-
Notifications
You must be signed in to change notification settings - Fork 944
feature: add pouch port cmd #2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add pouch port cmd #2895
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2895 +/- ##
==========================================
- Coverage 68.9% 67.77% -1.14%
==========================================
Files 291 291
Lines 18251 18251
==========================================
- Hits 12576 12369 -207
- Misses 4222 4404 +182
- Partials 1453 1478 +25
|
|
Thanks for your contribution. 🍻 @yeya24 |
|
We found this is your first time to contribute to pouch, @yeya24 |
8aaa5f4 to
29d3f13
Compare
Signed-off-by: yeya24 <[email protected]> fix example Signed-off-by: yeya24 <[email protected]> add one arg example to test Signed-off-by: yeya24 <[email protected]>
29d3f13 to
22d6cc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
LGTM |
Signed-off-by: yeya24 [email protected]
Ⅰ. Describe what this PR did
support
pouch portcmd.Ⅱ. Does this pull request fix one issue?
fix part of #238
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
I have added it.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews