Skip to content

Conversation

@yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 5, 2019

Signed-off-by: yeya24 [email protected]

Ⅰ. Describe what this PR did

support pouch port cmd.

Ⅱ. Does this pull request fix one issue?

fix part of #238

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

I have added it.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #2895 into master will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage    68.9%   67.77%   -1.14%     
==========================================
  Files         291      291              
  Lines       18251    18251              
==========================================
- Hits        12576    12369     -207     
- Misses       4222     4404     +182     
- Partials     1453     1478      +25
Flag Coverage Δ
#criv1alpha2_test 38.39% <ø> (ø) ⬆️
#integration_test_0 36.22% <ø> (-0.02%) ⬇️
#integration_test_1 35.68% <ø> (ø) ⬆️
#integration_test_2 36.17% <ø> (-0.01%) ⬇️
#integration_test_3 35.76% <ø> (+0.22%) ⬆️
#node_e2e_test ?
#unittest 28.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/stream/remotecommand/websocket.go 0% <0%> (-81.54%) ⬇️
cri/stream/remotecommand/exec.go 36.66% <0%> (-43.34%) ⬇️
cri/stream/remotecommand/errors.go 14.28% <0%> (-14.29%) ⬇️
cri/v1alpha2/cri.go 60.6% <0%> (-8.72%) ⬇️
cri/ocicni/netns.go 52.7% <0%> (-5.41%) ⬇️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
daemon/logger/jsonfile/encode.go 78.26% <0%> (-3.27%) ⬇️
daemon/logger/crilog/log.go 79.71% <0%> (-2.9%) ⬇️
cri/stream/remotecommand/httpstream.go 44.04% <0%> (-2.6%) ⬇️
... and 12 more

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @yeya24
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @yeya24
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@yeya24 yeya24 changed the title feature/add-port-cmd feature: add pouch port cmd Jun 5, 2019
Signed-off-by: yeya24 <[email protected]>

fix example

Signed-off-by: yeya24 <[email protected]>

add one arg example to test

Signed-off-by: yeya24 <[email protected]>
@yeya24 yeya24 force-pushed the feature/add-port-cmd branch from 29d3f13 to 22d6cc1 Compare June 10, 2019 02:46
Copy link
Contributor

@ZYecho ZYecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 10, 2019
@allencloud allencloud merged commit 772c9bf into AliyunContainerService:master Jun 10, 2019
@yeya24 yeya24 deleted the feature/add-port-cmd branch June 10, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants