copy command: bug fix and enhance #2890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Fu <[email protected]>
The /dev/ /tmp /proc are default mount point from oci spec. They are not in the container mount points. When we pass the /dev/terminal-log as dest, it will mount after the /dev, which handed by runC in the special namespace. But when we try to mount for copy, we don't have /dev folder or sub folder, we need to create parent folder for the target or empty file. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2890 +/- ##
=========================================
- Coverage 68.91% 68.8% -0.11%
=========================================
Files 291 291
Lines 18230 18249 +19
=========================================
- Hits 12563 12557 -6
- Misses 4215 4236 +21
- Partials 1452 1456 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
has cases
Ⅳ. Describe how to verify it
wait for CI
Ⅴ. Special notes for reviews