Skip to content

Conversation

@KevinBetterQ
Copy link
Contributor

Ⅰ. Describe what this PR did

fix golint warning:

  1. pouch/daemon/config/config.go
    Line 183: warning: redundant if ...; err != nil check, just return error instead. (golint)
  2. pouch/cri/v1alpha2/cri_utils.go
    Line 320: warning: redundant if ...; err != nil check, just return error instead. (golint)

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #2821 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
+ Coverage   69.35%   69.37%   +0.01%     
==========================================
  Files         278      278              
  Lines       17448    17444       -4     
==========================================
  Hits        12101    12101              
+ Misses       3995     3993       -2     
+ Partials     1352     1350       -2
Flag Coverage Δ
#criv1alpha2_test 39.22% <100%> (-0.03%) ⬇️
#integration_test_0 36.51% <50%> (-0.03%) ⬇️
#integration_test_1 35.37% <50%> (+0.04%) ⬆️
#integration_test_2 36.51% <50%> (+0.03%) ⬆️
#integration_test_3 35.41% <50%> (+0.08%) ⬆️
#node_e2e_test 34.96% <100%> (-0.07%) ⬇️
#unittest 28.75% <50%> (ø) ⬆️
Impacted Files Coverage Δ
daemon/config/config.go 69.51% <100%> (+1.65%) ⬆️
cri/v1alpha2/cri_utils.go 89.07% <100%> (+0.23%) ⬆️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 82.38% <0%> (-1.14%) ⬇️
cri/v1alpha2/cri.go 71.22% <0%> (ø) ⬆️
ctrd/watch.go 78.37% <0%> (+5.4%) ⬆️

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2019

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @KevinBetterQ
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@fuweid
Copy link
Contributor

fuweid commented Apr 30, 2019

@KevinBetterQ please git commit -s --amend --no-edit and repush again. thanks

Signed-off-by: KevinBetterQ <[email protected]>

Author:    KevinBetterQ [email protected]>
Date:      Tue Apr 30 19:09:32 2019 +0800
Signed-off-by: KevinBetterQ <[email protected]>
@allencloud
Copy link
Collaborator

Thanks for your work. LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 2, 2019
@allencloud allencloud merged commit 246d786 into AliyunContainerService:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants